[compiler-v1] Omit warning for unused self parameter

[wrwg]

Description

This omits the warning for unused self parameters in the v1 compiler, in case we run it on v2 code.
v2 does already omit the warning.

Fixes #14361

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Added test cases for both v1 and v2.

[trunk-io]

⏱️ 8h 53m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
forge-framework-upgrade-test / forge	1h 28m	⬜ 🟥 🟥 🟥 🟩 (+1 more)
forge-compat-test / forge	1h 21m	🟥 🟥 🟥 🟩 🟩 (+1 more)
execution-performance / single-node-performance	1h 8m	🟩 🟩 🟩
forge-e2e-test / forge	1h 1m	🟩 🟩 🟥 🟩
rust-images / rust-all	18m	🟥 🟩
test-target-determinator	17m	🟩 🟩 🟩 🟩
rust-cargo-deny	16m	🟩 🟩 🟩 🟩 🟩 (+4 more)
general-lints	16m	🟩 🟩 🟩 🟩 🟩 (+4 more)
execution-performance / test-target-determinator	13m	🟩 🟩 🟩
check	11m	🟩 🟩 🟩
rust-move-unit-coverage	10m	🟩
check-dynamic-deps	10m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-tests	9m	🟩
rust-move-unit-coverage	9m	🟩
rust-move-tests	9m	🟩
rust-move-tests	8m	🟩
rust-move-unit-coverage	8m	⬜
rust-move-tests	8m	⬜
rust-move-tests	8m	⬜
cli-e2e-tests / run-cli-tests	7m	🟩
rust-move-unit-coverage	7m	🟥
rust-doc-tests	5m	🟩
rust-move-tests	5m	⬜
rust-doc-tests	5m	🟩
rust-move-unit-coverage	5m	⬜
rust-doc-tests	4m	🟩
semgrep/ci	4m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-unit-coverage	3m	⬜
rust-move-tests	3m	⬜
rust-move-unit-coverage	3m	⬜
rust-move-tests	3m	⬜
rust-move-tests	2m	⬜
rust-move-unit-coverage	2m	⬜
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
node-api-compatibility-tests / node-api-compatibility-tests	1m	🟩
file_change_determinator	42s	🟩 🟩 🟩 🟩
permission-check	37s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	34s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	25s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	12s	🟩 🟩 🟩 🟩
determine-docker-build-metadata	6s	🟩 🟩 🟩 🟩
Backport PR	4s	🟥
permission-check	2s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	25m	17m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[wrwg]

• [compiler-v1] Omit warning for unused self parameter #14368 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite

[brmataptos]

Still need to do V2.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.4%. Comparing base (a482050) to head (b06e5e8).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14368   +/-   ##
=======================================
  Coverage    59.4%    59.4%           
=======================================
  Files         838      838           
  Lines      204392   204401    +9     
=======================================
+ Hits       121562   121571    +9     
  Misses      82830    82830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

✅ Forge suite realistic_env_max_load success on c68c451df94f9ed1e29e78951d21777afa32fb02

two traffics test: inner traffic : committed: 12099.82 txn/s, latency: 3290.59 ms, (p50: 3200 ms, p90: 3600 ms, p99: 4200 ms), latency samples: 4600620
two traffics test : committed: 99.90 txn/s, latency: 2610.80 ms, (p50: 2600 ms, p90: 2900 ms, p99: 3600 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.255, avg: 0.223", "QsPosToProposal: max: 0.511, avg: 0.442", "ConsensusProposalToOrdered: max: 0.336, avg: 0.326", "ConsensusOrderedToCommit: max: 0.677, avg: 0.602", "ConsensusProposalToCommit: max: 1.005, avg: 0.928"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.92s no progress at version 2247911 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.64s no progress at version 2247909 (avg 7.64s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c68c451df94f9ed1e29e78951d21777afa32fb02

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c68c451df94f9ed1e29e78951d21777afa32fb02 (PR)
1. Check liveness of validators at old version: d1bf834728a0cf166d993f4728dfca54f3086fb0
compatibility::simple-validator-upgrade::liveness-check : committed: 11417.52 txn/s, latency: 2887.02 ms, (p50: 2400 ms, p90: 5900 ms, p99: 8100 ms), latency samples: 384120
2. Upgrading first Validator to new version: c68c451df94f9ed1e29e78951d21777afa32fb02
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7523.04 txn/s, latency: 3736.79 ms, (p50: 4200 ms, p90: 4600 ms, p99: 4700 ms), latency samples: 139040
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7700.04 txn/s, latency: 4169.89 ms, (p50: 4500 ms, p90: 5600 ms, p99: 6100 ms), latency samples: 258620
3. Upgrading rest of first batch to new version: c68c451df94f9ed1e29e78951d21777afa32fb02
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7390.84 txn/s, latency: 3756.61 ms, (p50: 4000 ms, p90: 5100 ms, p99: 5500 ms), latency samples: 139760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7083.22 txn/s, latency: 4551.69 ms, (p50: 4800 ms, p90: 6200 ms, p99: 6700 ms), latency samples: 239760
4. upgrading second batch to new version: c68c451df94f9ed1e29e78951d21777afa32fb02
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11208.03 txn/s, latency: 2363.18 ms, (p50: 2500 ms, p90: 2900 ms, p99: 3400 ms), latency samples: 203480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12117.20 txn/s, latency: 2637.18 ms, (p50: 2600 ms, p90: 3100 ms, p99: 3700 ms), latency samples: 396720
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c68c451df94f9ed1e29e78951d21777afa32fb02 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c68c451df94f9ed1e29e78951d21777afa32fb02

Compatibility test results for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c68c451df94f9ed1e29e78951d21777afa32fb02 (PR)
Upgrade the nodes to version: c68c451df94f9ed1e29e78951d21777afa32fb02
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1220.98 txn/s, submitted: 1223.74 txn/s, failed submission: 2.76 txn/s, expired: 2.76 txn/s, latency: 2604.33 ms, (p50: 2400 ms, p90: 4500 ms, p99: 5700 ms), latency samples: 106300
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1128.94 txn/s, submitted: 1130.77 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2787.53 ms, (p50: 2400 ms, p90: 4500 ms, p99: 6600 ms), latency samples: 99060
5. check swarm health
Compatibility test for d1bf834728a0cf166d993f4728dfca54f3086fb0 ==> c68c451df94f9ed1e29e78951d21777afa32fb02 passed
Upgrade the remaining nodes to version: c68c451df94f9ed1e29e78951d21777afa32fb02
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 596.03 txn/s, submitted: 596.49 txn/s, failed submission: 0.45 txn/s, expired: 0.45 txn/s, latency: 5151.41 ms, (p50: 5400 ms, p90: 8400 ms, p99: 10500 ms), latency samples: 52500
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking