Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] Performance test #14738

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 24, 2024

⏱️ 1h 30m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 24m 🟥🟥
execution-performance / test-target-determinator 12m 🟩🟩🟩
rust-move-unit-coverage 12m 🟩
rust-move-tests 10m 🟥
rust-move-tests 10m 🟥
test-target-determinator 7m 🟩🟩
rust-cargo-deny 4m 🟩🟩
general-lints 4m 🟩🟩
check-dynamic-deps 3m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 36s 🟩🟩🟩
file_change_determinator 33s 🟩🟩🟩
file_change_determinator 26s 🟩🟩
Backport PR 16s 🟥🟥🟥
permission-check 11s 🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
rust-move-tests 8s
permission-check 8s 🟩🟩🟩
permission-check 7s 🟩🟩🟩
determine-docker-build-metadata 6s 🟩🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / test-target-determinator 3m 4m -24%
test-target-determinator 3m 4m -25%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

georgemitenkov commented Sep 24, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite Graphite

@georgemitenkov georgemitenkov added the CICD:run-execution-performance-full-test Run execution performance test (full version) label Sep 24, 2024
@georgemitenkov georgemitenkov marked this pull request as ready for review September 24, 2024 17:36
@georgemitenkov georgemitenkov changed the title Tmp change to test performance [IGNORE] Performance test Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 59.1%. Comparing base (44fda2e) to head (7c2c135).

Files with missing lines Patch % Lines
aptos-move/aptos-vm/src/block_executor/mod.rs 0.0% 18 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           george/main   #14738     +/-   ##
==============================================
- Coverage         59.1%    59.1%   -0.1%     
==============================================
  Files              868      868             
  Lines           210356   210373     +17     
==============================================
  Hits            124361   124361             
- Misses           85995    86012     +17     
Flag Coverage Δ
59.1% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgemitenkov georgemitenkov added the CICD:run-execution-performance-test Run execution performance test label Sep 24, 2024
@georgemitenkov georgemitenkov removed CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Sep 24, 2024
@georgemitenkov georgemitenkov deleted the george/main-with-long-living-ty-name-caches branch September 25, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant