-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aptos-vm] init_module & state value metadata for V2 loader #14341
Conversation
⏱️ 2h 53m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @georgemitenkov and the rest of your teammates on Graphite |
/// Returns the state value metadata of an associated with this module. The | ||
/// error is returned if there is a storage error. If the module does not exist, | ||
/// `None` is returned. | ||
fn fetch_state_value_metadata( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we make sure to cleanly separate the functionality and apis vs the executor view traits? do the module interfaces just move here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! ModuleView
is no longer needed, we have all the traits here, so this essentially merges executor traits into here. The reason is that we do not really need an adapter for modules, and we want to have a separate flow from data ideally. Block-STM will implement AptosModuleStorage
directly.
Block-STM is generic, but I also previously added a trait method to convert addresses, module names into generic K: ModulePath
(state keys) so we are good there as well.
d7437e8
to
94789cc
Compare
d22c597
to
d550646
Compare
94789cc
to
7201bf9
Compare
d550646
to
f7a4c4d
Compare
7201bf9
to
30513a3
Compare
d41c9de
to
e83efcd
Compare
1510c6f
to
83c8549
Compare
e83efcd
to
a3ea4b8
Compare
83c8549
to
7f5926b
Compare
a3ea4b8
to
79f0950
Compare
7f5926b
to
6ff9ff2
Compare
79f0950
to
05a1a3c
Compare
6ff9ff2
to
6eaf5d4
Compare
6eaf5d4
to
f841350
Compare
@gelash merging this because init module here is not correct anyway, and metadata is trivial + added tests and addressed your comments. |
Description
Two changes:
AptosModuleStorage
to query state value metadata.Note: tests 2will come when things are connected e2e.
Kept them as a separate PR for simplicity. This way it is easier to address all
TODO(loader_v2)
s...Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist