Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] V1 loader enabled #14808

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Sep 30, 2024

⏱️ 1h 20m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 36m 🟩
rust-move-unit-coverage 16m 🟩
rust-move-tests 9m 🟥
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
general-lints 3m 🟩
check-dynamic-deps 2m 🟩🟩
rust-cargo-deny 2m 🟩
rust-move-tests 1m
semgrep/ci 46s 🟩🟩
file_change_determinator 22s 🟩🟩
file_change_determinator 19s 🟩🟩
permission-check 11s 🟩🟩
file_change_determinator 10s 🟩
Backport PR 8s 🟥🟥

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 36m 18m +96%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

georgemitenkov commented Sep 30, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite Graphite

@georgemitenkov georgemitenkov marked this pull request as ready for review September 30, 2024 21:58
@georgemitenkov georgemitenkov added the CICD:run-execution-performance-full-test Run execution performance test (full version) label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (george/main-with-long-living-cache-option@a0e01ce). Learn more about missing BASE report.

Files with missing lines Patch % Lines
aptos-move/aptos-vm-environment/src/environment.rs 0.0% 5 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##             george/main-with-long-living-cache-option   #14808   +/-   ##
============================================================================
  Coverage                                             ?    59.3%           
============================================================================
  Files                                                ?      870           
  Lines                                                ?   210505           
  Branches                                             ?        0           
============================================================================
  Hits                                                 ?   124913           
  Misses                                               ?    85592           
  Partials                                             ?        0           
Flag Coverage Δ
59.3% <28.5%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgemitenkov georgemitenkov deleted the george/main-with-long-living-cache-option-v1-loader branch October 1, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-execution-performance-full-test Run execution performance test (full version)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant