-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crypto+move] added support for SHA2-512, SHA3-512 and RIPEMD-160 in Move #4181
Conversation
Forge is running suite
|
Forge is running suite
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty trivial PR.
two questions...
what happens if we use this software with the current network? would it load fine without the gas schedule available?
could you validate that you can connect to testnet as a fullnode and submit a transaction?
looks good otherwise, will approve with those validations and a little more time.
@alinush yeah as we discussed offline, I'm currently busy with some urgent hotfixes... Let's try not to land this before launch. We'll get back to it later |
3b016bc
to
12eb39c
Compare
12eb39c
to
fa58ea7
Compare
@davidiw, this PR is ready to be approved now:
...whenever you are ready! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Description
Added support for SHA2-512, SHA3-512 and RIPEMD-160, to support folks write bridge contracts to other platforms, as per conversations with @JoshLind.
This PR should be good to go:
optional
Test Plan
This PR merely exports existing hash function crates, which are either already used throughout
aptos-core/
or are believed to be trustworthy implementations. Therefore, we only made sure the native implementation give the expected hash values for the empty string "" and forb"testing"
.This change is