[crypto+move] add support for Blake2b-256 in Move #5436

blasrodri · 2022-11-03T21:48:12Z

Taken a lot of inspiration from #4181 (comment)

Description

Add Blake2b-256 hashing in Move, to support folks writing bridge contracts to other platforms, as per conversations with @JoshLind and @alinush.

it is feature-gated
it has (reasonable) gas costs for the new hash functions

Test Plan

This PR merely exports an existing hash function crate (i.e.: blake2_rfc), which are is believed to be trustworthy implementation as it's used in Substrate (https://crates.io/crates/sp-core-hashing/4.0.0/dependencies). Therefore, we only made sure the native implementation give the expected hash values for b"", b"testing" and b"testing again".

This change is

alinush · 2022-11-04T03:15:47Z

Thank you for the PR @blasrodri!

There are two flavors of Blake: Blake2b, Blake2s (see https://www.blake2.net/).

Can you please update the PR title and all of the code (e.g., function names, gas parameter names, comments, etc.) to clearly indicate which one you are implementing?

…2_rfc

alinush · 2022-11-04T18:10:23Z

Thank you for the update @blasrodri! Can you include in the PR's description the performance impact of going from blake2 crate to blake2-rfc?

blasrodri · 2022-11-04T18:12:35Z

Thank you for the update @blasrodri! Can you include in the PR's description the performance impact of going from blake2 crate to blake2-rfc?

Oh it's just because i checked the Substrate implemention and it uses blake2_rfc. But ill do a quick benchmark, and post the results. So that we can pick the better one ☺️

blasrodri · 2022-11-05T10:05:26Z

blake2 seems to be faster than blake2-rfc

use blake2::{
    digest::{Update, VariableOutput},
    Blake2bVar,
};
use criterion::{black_box, criterion_group, criterion_main, Criterion};

fn blake2_blake2b_256(data: &[u8]) -> Vec<u8> {
    // Blake2bVarCore::new_with_params(salt, persona, key_size, output_size)
    let mut hasher = Blake2bVar::new(32).unwrap();
    hasher.update(data);
    let mut buf = vec![0u8; 32];
    hasher.finalize_variable(&mut buf).unwrap();
    buf
}

fn blake2_rfc_blake2b_256(data: &[u8]) -> Vec<u8> {
    blake2_blake2b_256(data).to_vec()
}

fn criterion_benchmark(c: &mut Criterion) {
    assert_eq!(
        blake2_blake2b_256(b"testing"),
        blake2_rfc_blake2b_256(b"testing")
    );
    c.bench_function("blake2_blake2b_256", |b| {
        b.iter(|| blake2_blake2b_256(black_box(b"testing")))
    });
    c.bench_function("blake2_rfc_blake2b_256", |b| {
        b.iter(|| blake2_rfc_blake2b_256(black_box(b"testing")))
    });
}

criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);

blas@f1:~/foss/blak2-benchmarks$ cargo bench
   Compiling blak2-benchmarks v0.1.0 (/home/blas/foss/blak2-benchmarks)
    Finished bench [optimized] target(s) in 0.79s
     Running unittests src/main.rs (target/release/deps/blak2_benchmarks-c07cbf1492157f71)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/blake2.rs (target/release/deps/blake2-ee4b1cddd724fc46)
blake2_blake2b_256      time:   [123.94 ns 124.07 ns 124.21 ns]
                        change: [-0.2375% +0.0861% +0.3560%] (p = 0.59 > 0.05)
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  8 (8.00%) high mild
  2 (2.00%) high severe

blake2_rfc_blake2b_256  time:   [142.25 ns 142.37 ns 142.51 ns]
                        change: [-0.7492% -0.6241% -0.4932%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

blas@f1:~/foss/blak2-benchmarks$ cargo bench
    Finished bench [optimized] target(s) in 0.02s
     Running unittests src/main.rs (target/release/deps/blak2_benchmarks-c07cbf1492157f71)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/blake2.rs (target/release/deps/blake2-ee4b1cddd724fc46)
blake2_blake2b_256      time:   [122.38 ns 122.51 ns 122.64 ns]
                        change: [-1.5252% -1.3730% -1.2095%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe

blake2_rfc_blake2b_256  time:   [139.35 ns 139.51 ns 139.71 ns]
                        change: [-1.8661% -1.6701% -1.4750%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

alinush · 2022-11-05T14:19:20Z

blake2 seems to be faster than blake2-rfc

use blake2::{
    digest::{Update, VariableOutput},
    Blake2bVar,
};
use criterion::{black_box, criterion_group, criterion_main, Criterion};

fn blake2_blake2b_256(data: &[u8]) -> Vec<u8> {
    // Blake2bVarCore::new_with_params(salt, persona, key_size, output_size)
    let mut hasher = Blake2bVar::new(32).unwrap();
    hasher.update(data);
    let mut buf = vec![0u8; 32];
    hasher.finalize_variable(&mut buf).unwrap();
    buf
}

fn blake2_rfc_blake2b_256(data: &[u8]) -> Vec<u8> {
    blake2_blake2b_256(data).to_vec()
}

fn criterion_benchmark(c: &mut Criterion) {
    assert_eq!(
        blake2_blake2b_256(b"testing"),
        blake2_rfc_blake2b_256(b"testing")
    );
    c.bench_function("blake2_blake2b_256", |b| {
        b.iter(|| blake2_blake2b_256(black_box(b"testing")))
    });
    c.bench_function("blake2_rfc_blake2b_256", |b| {
        b.iter(|| blake2_rfc_blake2b_256(black_box(b"testing")))
    });
}

criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);

blas@f1:~/foss/blak2-benchmarks$ cargo bench
   Compiling blak2-benchmarks v0.1.0 (/home/blas/foss/blak2-benchmarks)
    Finished bench [optimized] target(s) in 0.79s
     Running unittests src/main.rs (target/release/deps/blak2_benchmarks-c07cbf1492157f71)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/blake2.rs (target/release/deps/blake2-ee4b1cddd724fc46)
blake2_blake2b_256      time:   [123.94 ns 124.07 ns 124.21 ns]
                        change: [-0.2375% +0.0861% +0.3560%] (p = 0.59 > 0.05)
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  8 (8.00%) high mild
  2 (2.00%) high severe

blake2_rfc_blake2b_256  time:   [142.25 ns 142.37 ns 142.51 ns]
                        change: [-0.7492% -0.6241% -0.4932%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

blas@f1:~/foss/blak2-benchmarks$ cargo bench
    Finished bench [optimized] target(s) in 0.02s
     Running unittests src/main.rs (target/release/deps/blak2_benchmarks-c07cbf1492157f71)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/blake2.rs (target/release/deps/blake2-ee4b1cddd724fc46)
blake2_blake2b_256      time:   [122.38 ns 122.51 ns 122.64 ns]
                        change: [-1.5252% -1.3730% -1.2095%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe

blake2_rfc_blake2b_256  time:   [139.35 ns 139.51 ns 139.71 ns]
                        change: [-1.8661% -1.6701% -1.4750%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Thank you @blasrodri! Let's stick to blake2 in that case.

Could you please add your benchmarks to this hash.rs file in crates/aptos-crypto/benches/?

This will help me estimate gas costs more accurately.

blasrodri · 2022-11-06T20:30:27Z

blake2 seems to be faster than blake2-rfc

use blake2::{
    digest::{Update, VariableOutput},
    Blake2bVar,
};
use criterion::{black_box, criterion_group, criterion_main, Criterion};

fn blake2_blake2b_256(data: &[u8]) -> Vec<u8> {
    // Blake2bVarCore::new_with_params(salt, persona, key_size, output_size)
    let mut hasher = Blake2bVar::new(32).unwrap();
    hasher.update(data);
    let mut buf = vec![0u8; 32];
    hasher.finalize_variable(&mut buf).unwrap();
    buf
}

fn blake2_rfc_blake2b_256(data: &[u8]) -> Vec<u8> {
    blake2_blake2b_256(data).to_vec()
}

fn criterion_benchmark(c: &mut Criterion) {
    assert_eq!(
        blake2_blake2b_256(b"testing"),
        blake2_rfc_blake2b_256(b"testing")
    );
    c.bench_function("blake2_blake2b_256", |b| {
        b.iter(|| blake2_blake2b_256(black_box(b"testing")))
    });
    c.bench_function("blake2_rfc_blake2b_256", |b| {
        b.iter(|| blake2_rfc_blake2b_256(black_box(b"testing")))
    });
}

criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);

blas@f1:~/foss/blak2-benchmarks$ cargo bench
   Compiling blak2-benchmarks v0.1.0 (/home/blas/foss/blak2-benchmarks)
    Finished bench [optimized] target(s) in 0.79s
     Running unittests src/main.rs (target/release/deps/blak2_benchmarks-c07cbf1492157f71)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/blake2.rs (target/release/deps/blake2-ee4b1cddd724fc46)
blake2_blake2b_256      time:   [123.94 ns 124.07 ns 124.21 ns]
                        change: [-0.2375% +0.0861% +0.3560%] (p = 0.59 > 0.05)
                        No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
  8 (8.00%) high mild
  2 (2.00%) high severe

blake2_rfc_blake2b_256  time:   [142.25 ns 142.37 ns 142.51 ns]
                        change: [-0.7492% -0.6241% -0.4932%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high mild

blas@f1:~/foss/blak2-benchmarks$ cargo bench
    Finished bench [optimized] target(s) in 0.02s
     Running unittests src/main.rs (target/release/deps/blak2_benchmarks-c07cbf1492157f71)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running benches/blake2.rs (target/release/deps/blake2-ee4b1cddd724fc46)
blake2_blake2b_256      time:   [122.38 ns 122.51 ns 122.64 ns]
                        change: [-1.5252% -1.3730% -1.2095%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe

blake2_rfc_blake2b_256  time:   [139.35 ns 139.51 ns 139.71 ns]
                        change: [-1.8661% -1.6701% -1.4750%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Thank you @blasrodri! Let's stick to blake2 in that case.

Could you please add your benchmarks to this hash.rs file in crates/aptos-crypto/benches/?

This will help me estimate gas costs more accurately.

I made a mistake on the previous script. Now, I've added the two implementations on the hash.rs bench, and these
are the results:

hash/BLAKE2B-256-blake2-crate/0                                                                             
                        time:   [156.02 ns 156.21 ns 156.39 ns]
                        thrpt:  [0.0000   B/s 0.0000   B/s 0.0000   B/s]
                 change:
                        time:   [+0.3640% +0.5418% +0.7898%] (p = 0.00 < 0.05)
                        thrpt:  [-0.7836% -0.5389% -0.3627%]
                        Change within noise threshold.
Found 32 outliers among 1000 measurements (3.20%)
  16 (1.60%) high mild
  16 (1.60%) high severe
hash/BLAKE2B-256-blake2-rfc-crate/0                                                                             
                        time:   [125.81 ns 125.89 ns 125.97 ns]
                        thrpt:  [0.0000   B/s 0.0000   B/s 0.0000   B/s]
                 change:
                        time:   [+0.2890% +0.4097% +0.5219%] (p = 0.00 < 0.05)
                        thrpt:  [-0.5192% -0.4080% -0.2882%]
                        Change within noise threshold.

hash/BLAKE2B-256-blake2-crate/1                                                                             
                        time:   [171.15 ns 171.28 ns 171.40 ns]
                        thrpt:  [5.5640 MiB/s 5.5681 MiB/s 5.5720 MiB/s]
                 change:
                        time:   [+10.641% +10.729% +10.818%] (p = 0.00 < 0.05)
                        thrpt:  [-9.7620% -9.6898% -9.6175%]
                        Performance has regressed.
Found 26 outliers among 1000 measurements (2.60%)
  22 (2.20%) high mild
  4 (0.40%) high severe
hash/BLAKE2B-256-blake2-rfc-crate/1                                                                             
                        time:   [134.56 ns 134.72 ns 134.90 ns]
                        thrpt:  [7.0693 MiB/s 7.0788 MiB/s 7.0874 MiB/s]
                 change:
                        time:   [-1.2537% -1.0534% -0.8347%] (p = 0.00 < 0.05)
                        thrpt:  [+0.8417% +1.0646% +1.2696%]
                        Change within noise threshold.
Found 11 outliers among 1000 measurements (1.10%)
  8 (0.80%) high mild
  3 (0.30%) high severe

alinush · 2022-11-06T20:40:41Z

Sweet! I forgot to ask the most obvious question: are these numbers for x86_64?

blasrodri · 2022-11-06T20:58:13Z

Sweet! I forgot to ask the most obvious question: are these numbers for x86_64?

Yes ^_^

blas@f1:~$ uname -m
x86_64

aptos-move/framework/aptos-stdlib/sources/hash.move

alinush · 2022-11-18T18:15:28Z

...move/e2e-move-tests/src/tests/code_publishing.data/pack_stdlib/sources/configs/features.move

+    /// Whether the new BLAKE2B-256 hash function natives is enabled.
+    /// This is needed because of the introduction of new native functions.
+    /// Lifetime: transient
+    const BLAKE2B_256_NATIVE: u64 = 5;


Just a heads up that this might need to be further bumped up given recent changes. We'll have to see.

I see no issues here.

aptos-move/framework/move-stdlib/sources/configs/features.move

alinush · 2022-11-18T18:22:23Z

One more request, since you are adding new gas parameters, you will need to bump up the LATEST_GAS_FEATURE_VERSION in aptos-move/aptos-gas/src/gas_meter.rs (e.g., see this).

Right, @vgao1996? (Sorry, I keep forgetting this.)

alinush · 2022-11-18T18:24:29Z

Sweet! I forgot to ask the most obvious question: are these numbers for x86_64?

Yes ^_^
blas@f1:~$ uname -m
x86_64

Another request: could you re-run benchmarks both for SHA2-256 and your newly-added Blake2b function and post the results here? This will allow us to calibrate the gas costs a little better.

The SHA2-256 ones are also in aptos-crypto/benches/hash.rs

blasrodri · 2022-11-23T09:53:16Z

Sweet! I forgot to ask the most obvious question: are these numbers for x86_64?

Yes ^_^
blas@f1:~$ uname -m
x86_64
Another request: could you re-run benchmarks both for SHA2-256 and your newly-added Blake2b function and post the results here? This will allow us to calibrate the gas costs a little better.

The SHA2-256 ones are also in aptos-crypto/benches/hash.rs

Sure! Will do it today

blasrodri · 2022-11-23T14:11:10Z

SHA2

hash/SHA2-256/0         time:   [71.395 ns 71.552 ns 71.720 ns]                             
                        thrpt:  [0.0000   B/s 0.0000   B/s 0.0000   B/s]
                 change:
                        time:   [+4.6839% +4.9618% +5.2726%] (p = 0.00 < 0.05)
                        thrpt:  [-5.0086% -4.7273% -4.4743%]
                        Performance has regressed.
Found 53 outliers among 1000 measurements (5.30%)
  19 (1.90%) high mild
  34 (3.40%) high severe
hash/SHA2-256/8         time:   [72.274 ns 72.323 ns 72.374 ns]                             
                        thrpt:  [105.42 MiB/s 105.49 MiB/s 105.56 MiB/s]
                 change:
                        time:   [+0.9191% +1.1247% +1.3492%] (p = 0.00 < 0.05)
                        thrpt:  [-1.3312% -1.1122% -0.9108%]
                        Change within noise threshold.
Found 4 outliers among 1000 measurements (0.40%)
  2 (0.20%) high mild
  2 (0.20%) high severe
hash/SHA2-256/16        time:   [67.068 ns 67.177 ns 67.301 ns]                              
                        thrpt:  [226.72 MiB/s 227.14 MiB/s 227.51 MiB/s]
                 change:
                        time:   [-5.5021% -5.3377% -5.1669%] (p = 0.00 < 0.05)
                        thrpt:  [+5.4484% +5.6387% +5.8225%]
                        Performance has improved.
Found 94 outliers among 1000 measurements (9.40%)

BLAKE2B

hash/BLAKE2B-256-blake2-crate/2                                                                             
                        time:   [169.94 ns 170.12 ns 170.33 ns]
                        thrpt:  [11.198 MiB/s 11.212 MiB/s 11.223 MiB/s]
                 change:
                        time:   [-2.9107% -2.7912% -2.6447%] (p = 0.00 < 0.05)
                        thrpt:  [+2.7166% +2.8713% +2.9980%]
                        Performance has improved.
Found 23 outliers among 1000 measurements (2.30%)
  10 (1.00%) low mild
  7 (0.70%) high mild
  6 (0.60%) high severe

hash/BLAKE2B-256-blake2-rfc-crate/8                                                                             
                        time:   [132.83 ns 132.88 ns 132.94 ns]
                        thrpt:  [57.392 MiB/s 57.415 MiB/s 57.439 MiB/s]
                 change:
                        time:   [-4.1867% -3.7555% -3.3995%] (p = 0.00 < 0.05)
                        thrpt:  [+3.5191% +3.9020% +4.3696%]
                        Performance has improved.
Found 7 outliers among 1000 measurements (0.70%)

aptos-move/framework/Cargo.toml

aptos-move/framework/move-stdlib/sources/configs/features.move

Signed-off-by: Blas Rodriguez Irizar <rodrigblas@gmail.com>

davidiw · 2022-12-18T05:36:36Z

This branch has conflicts that must be resolved

Please rebase and fix on your end. I can potentially help, but I think there might be some gnarly changes.

alinush · 2022-12-19T16:15:41Z

I'm coordinating with Blas on re-basing and merging. No worries @davidiw.

github-actions · 2022-12-20T10:59:19Z

✅ Forge suite `land_blocking` success on `3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c`

performance benchmark with full nodes : 6665 TPS, 5953 ms latency, 9000 ms p99 latency,no expired txns
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

github-actions · 2022-12-20T11:01:27Z

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c`

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7284 TPS, 5331 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c
compatibility::simple-validator-upgrade::single-validator-upgrade : 4545 TPS, 8820 ms latency, 12600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c
compatibility::simple-validator-upgrade::half-validator-upgrade : 4296 TPS, 9750 ms latency, 12800 ms p99 latency,no expired txns
4. upgrading second batch to new version: 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6189 TPS, 6201 ms latency, 9200 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c passed
Test Ok

Grafana dashboard
Humio Logs
Test runner output
Test run is land-blocking

This reverts commit de212ad.

[crypto+move] added support for Blake2 256 in Move

eb73482

blasrodri requested review from areshand, alinush, junkil-park, davidiw, movekevin, wrwg and vgao1996 as code owners November 3, 2022 21:48

specify which type of blake2 (blake2B) and update dependency to blake…

5bb8e02

…2_rfc

fix bench

880f9aa

alinush changed the title ~~[crypto+move] added support for Blake2 256 in Move~~ [crypto+move] added support for Blake2b-256 in Move Nov 7, 2022

alinush changed the title ~~[crypto+move] added support for Blake2b-256 in Move~~ [crypto+move] add support for Blake2b-256 in Move Nov 7, 2022

movekevin reviewed Nov 16, 2022

View reviewed changes

aptos-move/framework/aptos-stdlib/sources/hash.move Outdated Show resolved Hide resolved

alinush reviewed Nov 18, 2022

View reviewed changes

aptos-move/framework/aptos-stdlib/sources/hash.move Outdated Show resolved Hide resolved

alinush reviewed Nov 18, 2022

View reviewed changes

aptos-move/framework/move-stdlib/sources/configs/features.move Outdated Show resolved Hide resolved

alinush requested a review from zjma November 18, 2022 19:52

rm TODOs in docs

3d9e9d0

movekevin approved these changes Dec 18, 2022

View reviewed changes

aptos-move/framework/Cargo.toml Outdated Show resolved Hide resolved

aptos-move/framework/move-stdlib/sources/configs/features.move Outdated Show resolved Hide resolved

blasrodri added 2 commits December 17, 2022 22:42

address comments

ba9cdcc

Signed-off-by: Blas Rodriguez Irizar <rodrigblas@gmail.com>

re generated file

2e67931

Signed-off-by: Blas Rodriguez Irizar <rodrigblas@gmail.com>

davidiw enabled auto-merge (squash) December 18, 2022 04:48

This comment has been minimized.

Sign in to view

davidiw disabled auto-merge December 18, 2022 05:35

davidiw closed this Dec 18, 2022

davidiw reopened this Dec 18, 2022

alinush added 7 commits December 19, 2022 23:52

added empty hash

e4c49f4

added test for blake hash function aborting when feature is disabled

059091d

fixed features.move

4e616e4

fix e2e move test

a78fff0

Merge remote-tracking branch 'origin/main' into composable/move-blake2

2fbe0e2

Merge remote-tracking branch 'origin/main' into composable/move-blake2

1334d08

cargo.lcok

3fbc140

alinush enabled auto-merge (squash) December 20, 2022 10:14

This comment has been minimized.

Sign in to view

alinush merged commit de212ad into aptos-labs:main Dec 20, 2022

movekevin added a commit that referenced this pull request Dec 22, 2022

Revert "[crypto+move] add support for Blake2b-256 in Move (#5436)"

45071f7

This reverts commit de212ad.

movekevin mentioned this pull request Dec 22, 2022

Revert "[crypto+move] add support for Blake2b-256 in Move" #5984

Closed

Markuze mentioned this pull request Dec 26, 2022

markuze/aptos perf #5998

Closed

Markuze mentioned this pull request Jan 3, 2023

[Network] Adding AptosPerf Client #6054

Closed

This was referenced Jan 24, 2023

[gas] fix incorrect gas feature version for hash.blake2b_256 #6125

Merged

[Gas] Correct the gas schedule version for a recently added native function #5985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[crypto+move] add support for Blake2b-256 in Move #5436

[crypto+move] add support for Blake2b-256 in Move #5436

blasrodri commented Nov 3, 2022 •

edited by alinush

Loading

alinush commented Nov 4, 2022

alinush commented Nov 4, 2022

blasrodri commented Nov 4, 2022

blasrodri commented Nov 5, 2022

alinush commented Nov 5, 2022

blasrodri commented Nov 6, 2022

alinush commented Nov 6, 2022

blasrodri commented Nov 6, 2022 •

edited

Loading

alinush Nov 18, 2022

davidiw Dec 3, 2022

alinush commented Nov 18, 2022

alinush commented Nov 18, 2022 •

edited

Loading

blasrodri commented Nov 23, 2022

blasrodri commented Nov 23, 2022

This comment has been minimized.

This comment has been minimized.

davidiw commented Dec 18, 2022

alinush commented Dec 19, 2022

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 20, 2022

github-actions bot commented Dec 20, 2022

[crypto+move] add support for Blake2b-256 in Move #5436

[crypto+move] add support for Blake2b-256 in Move #5436

Conversation

blasrodri commented Nov 3, 2022 • edited by alinush Loading

Description

Test Plan

alinush commented Nov 4, 2022

alinush commented Nov 4, 2022

blasrodri commented Nov 4, 2022

blasrodri commented Nov 5, 2022

alinush commented Nov 5, 2022

blasrodri commented Nov 6, 2022

alinush commented Nov 6, 2022

blasrodri commented Nov 6, 2022 • edited Loading

alinush Nov 18, 2022

Choose a reason for hiding this comment

davidiw Dec 3, 2022

Choose a reason for hiding this comment

alinush commented Nov 18, 2022

alinush commented Nov 18, 2022 • edited Loading

blasrodri commented Nov 23, 2022

blasrodri commented Nov 23, 2022

This comment has been minimized.

This comment has been minimized.

davidiw commented Dec 18, 2022

alinush commented Dec 19, 2022

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Dec 20, 2022

✅ Forge suite land_blocking success on 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c

github-actions bot commented Dec 20, 2022

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c

blasrodri commented Nov 3, 2022 •

edited by alinush

Loading

blasrodri commented Nov 6, 2022 •

edited

Loading

alinush commented Nov 18, 2022 •

edited

Loading

✅ Forge suite `land_blocking` success on `3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c`

✅ Forge suite `compat` success on `testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b` ==> `3fbc1403be0e5377c9012c5ec44b7a8b42f97e6c`