-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-examples] Move to using _ placeholder notation in Move.toml #5955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xchloe
approved these changes
Dec 21, 2022
movekevin
approved these changes
Dec 21, 2022
aptos-move/move-examples/mint_nft/4-Getting-Production-Ready/Move.toml
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gregnazario
force-pushed
the
greg/move-examples
branch
from
December 21, 2022 08:17
cd5196c
to
bcd4a50
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I am curious "The build system doesn't particularly like it" in what way? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Compilation returns a weird error: |
gregnazario
force-pushed
the
greg/move-examples
branch
from
December 21, 2022 16:11
bcd4a50
to
711e092
Compare
movekevin
approved these changes
Dec 21, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
We can't use this, looks like we need changes to the unit test framework. I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The build system doesn't particularly like it when you provide an additional address for one that's hardcoded in the Move.toml. This changes to the placeholder notation.
Test Plan
CI should still pass if there's any automation that actually needed the fake addresses