Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move-examples] Move to using _ placeholder notation in Move.toml #5955

Closed
wants to merge 2 commits into from

Conversation

gregnazario
Copy link
Contributor

@gregnazario gregnazario commented Dec 21, 2022

Description

The build system doesn't particularly like it when you provide an additional address for one that's hardcoded in the Move.toml. This changes to the placeholder notation.

Test Plan

CI should still pass if there's any automation that actually needed the fake addresses

@gregnazario gregnazario enabled auto-merge (rebase) December 21, 2022 07:57
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@lightmark
Copy link
Contributor

I am curious "The build system doesn't particularly like it" in what way?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@movekevin
Copy link
Contributor

I am curious "The build system doesn't particularly like it" in what way?

Compilation returns a weird error:
{ "Error": "Unexpected error: Unable to resolve packages for package 'test_packages'" }

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gregnazario gregnazario enabled auto-merge (squash) December 21, 2022 22:10
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on cbba2b904c16c1c372fe7a66c968bba8a1b8daaf

performance benchmark with full nodes : 6095 TPS, 6447 ms latency, 13900 ms p99 latency,(!) expired 3120 out of 2605960 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> cbba2b904c16c1c372fe7a66c968bba8a1b8daaf

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> cbba2b904c16c1c372fe7a66c968bba8a1b8daaf (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7751 TPS, 5095 ms latency, 6800 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: cbba2b904c16c1c372fe7a66c968bba8a1b8daaf
compatibility::simple-validator-upgrade::single-validator-upgrade : 4846 TPS, 8502 ms latency, 10600 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: cbba2b904c16c1c372fe7a66c968bba8a1b8daaf
compatibility::simple-validator-upgrade::half-validator-upgrade : 4946 TPS, 8310 ms latency, 11400 ms p99 latency,no expired txns
4. upgrading second batch to new version: cbba2b904c16c1c372fe7a66c968bba8a1b8daaf
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6819 TPS, 5687 ms latency, 9400 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> cbba2b904c16c1c372fe7a66c968bba8a1b8daaf passed
Test Ok

@gregnazario
Copy link
Contributor Author

We can't use this, looks like we need changes to the unit test framework. I'm closing this for now.

auto-merge was automatically disabled December 28, 2022 20:36

Pull request was closed

@gregnazario gregnazario deleted the greg/move-examples branch December 28, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants