Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move-examples] changed option<u64> to u64 and added big_vec and buck… #5957

Merged
merged 1 commit into from
Dec 21, 2022
Merged

[move-examples] changed option<u64> to u64 and added big_vec and buck… #5957

merged 1 commit into from
Dec 21, 2022

Conversation

0xchloe
Copy link
Contributor

@0xchloe 0xchloe commented Dec 21, 2022

…et_table as part of the package

Description

Test Plan

lightmark
lightmark reviewed Dec 21, 2022
View reviewed changes
aptos-move/move-examples/post_mint_reveal_nft/Move.toml
@@ -9,4 +9,4 @@ AptosToken = { local = "../../framework/aptos-token" }
DataStructure = { local = "../data_structures" }

[addresses]
source_addr = "0xcafe"
source_addr = "_"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled in this PR #5955

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes https://github.com/aptos-labs/aptos-core/pull/5955/files/cd5196cc860e0d3646a1058218703b28a8b1fd15..bcd4a50a202504073d0748590ea09b63f488fd6e has more context

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then please rebase on PR #5955. Thanks for clarifying

@0xchloe 0xchloe enabled auto-merge (squash) December 21, 2022 08:39
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on a0f2388705871197acf37b8132ef7fad6f85f23a

performance benchmark with full nodes : 6501 TPS, 6131 ms latency, 10800 ms p99 latency,(!) expired 560 out of 2776760 txns
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a0f2388705871197acf37b8132ef7fad6f85f23a

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a0f2388705871197acf37b8132ef7fad6f85f23a (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 7266 TPS, 5349 ms latency, 7100 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: a0f2388705871197acf37b8132ef7fad6f85f23a
compatibility::simple-validator-upgrade::single-validator-upgrade : 4268 TPS, 9393 ms latency, 12100 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: a0f2388705871197acf37b8132ef7fad6f85f23a
compatibility::simple-validator-upgrade::half-validator-upgrade : 5062 TPS, 8144 ms latency, 10400 ms p99 latency,no expired txns
4. upgrading second batch to new version: a0f2388705871197acf37b8132ef7fad6f85f23a
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6608 TPS, 5820 ms latency, 12000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> a0f2388705871197acf37b8132ef7fad6f85f23a passed
Test Ok

@0xchloe 0xchloe merged commit f3cfcf1 into main Dec 21, 2022
@0xchloe 0xchloe deleted the nft branch December 21, 2022 09:24
@Markuze Markuze mentioned this pull request Dec 26, 2022
Closed
@Markuze Markuze mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@movekevin movekevin movekevin approved these changes

@lightmark lightmark lightmark approved these changes

@gregnazario gregnazario Awaiting requested review from gregnazario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xchloe @gregnazario @lightmark @movekevin