Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RemoveHTML.scala test coverage #56

Closed
ruebot opened this issue Oct 2, 2017 · 2 comments
Closed

Improve RemoveHTML.scala test coverage #56

ruebot opened this issue Oct 2, 2017 · 2 comments
Assignees
@greebie
Labels
tests

Comments

@ruebot
Copy link
Member

ruebot commented Oct 2, 2017

RemoveHTML.scala test coverage can be improved.
@ruebot ruebot added the tests label Oct 2, 2017
@greebie greebie self-assigned this Oct 4, 2017
@greebie greebie mentioned this issue Oct 4, 2017
Merged
@greebie greebie closed this as completed Oct 4, 2017
@greebie greebie reopened this Oct 4, 2017
@ruebot
Copy link
Member Author

ruebot commented Oct 5, 2017 •
edited
Loading

Need to address this line which was not covered in #84: https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/spark/matchbox/RemoveHTML.scala#L29

greebie added a commit that referenced this issue Oct 5, 2017
@greebie
Issues #56, #57, #58, #59, #61, #62
200bb9b
@greebie greebie mentioned this issue Oct 6, 2017
Merged
ruebot pushed a commit that referenced this issue Oct 6, 2017
@greebie @ruebot
Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63, …
c8b7d2e 
…#64 & #66 (#87)

* Add tests for remove Tuples, CreateGDF and RemoveHTML

* Add RemoveHttpHeader test.

* Add license header to tests.

* Issues #56, #57, #58, #59, #61, #62

* resolves Issue #85 (JsonUtil)

* Fix issue # 64 (ExtractDate coverage)

* Resolve Issue #63 (Extract Domain coverage)

* Fix error caused by repeated test names.
@greebie
Copy link
Contributor

greebie commented Oct 19, 2017

This one is to 100% now. Closing.

@greebie greebie closed this as completed Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greebie greebie

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greebie @ruebot