Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RecordLoader.scala test coverage #60

Closed
ruebot opened this issue Oct 2, 2017 · 7 comments
Closed

Improve RecordLoader.scala test coverage #60

ruebot opened this issue Oct 2, 2017 · 7 comments
Assignees
@greebie
Labels
RA-Task tests

Comments

@ruebot
Copy link
Member

ruebot commented Oct 2, 2017

RecordLoader.scala test coverage can be improved.
@ruebot ruebot added the tests label Oct 2, 2017
@greebie
Copy link
Contributor

greebie commented Oct 4, 2017

Going to start with this one for now.

@greebie greebie self-assigned this Oct 4, 2017
@greebie greebie mentioned this issue Oct 4, 2017
Merged
@greebie greebie closed this as completed Oct 4, 2017
@greebie greebie reopened this Oct 4, 2017
@ruebot
Copy link
Member Author

ruebot commented Oct 5, 2017

Couple more lines to cover here that #84 did not cover:
https://codecov.io/gh/archivesunleashed/aut/src/master/src/main/scala/io/archivesunleashed/spark/matchbox/RecordLoader.scala

@greebie greebie mentioned this issue Oct 6, 2017
Merged
ruebot pushed a commit that referenced this issue Oct 6, 2017
@greebie @ruebot
Improve Test Coverage for #55, #56, #57, #58, #59, #60, #61, #62, #63, …
c8b7d2e 
…#64 & #66 (#87)

* Add tests for remove Tuples, CreateGDF and RemoveHTML

* Add RemoveHttpHeader test.

* Add license header to tests.

* Issues #56, #57, #58, #59, #61, #62

* resolves Issue #85 (JsonUtil)

* Fix issue # 64 (ExtractDate coverage)

* Resolve Issue #63 (Extract Domain coverage)

* Fix error caused by repeated test names.
greebie added a commit that referenced this issue Oct 18, 2017
@greebie
Some slight test improvements for issues #60 & # 59.
f6c5210
@greebie greebie mentioned this issue Oct 18, 2017
Merged
ruebot pushed a commit that referenced this issue Oct 19, 2017
@greebie @ruebot
Improve coverage for issue-67 (RecordRDD.scala) (#99)
a539a1c 
* Improve coverage for issue-67 (RecordRDD.scala)

* Improve coverage for issue-67 (RecordRDD.scala)

* Fix partial covers for Issue #67

* Add badexample (with broken records)
Slight improvements to RecordRDD

* This may help improve coverage slightly. Altered badexample.

* Some slight test improvements for issues #60 & # 59.
@ruebot
Copy link
Member Author

ruebot commented Oct 19, 2017

Partially addressed with: a539a1c

@greebie greebie changed the title Improve RemoveHTML.scala test coverage Improve RemoveLoader.scala test coverage Dec 8, 2017
@greebie greebie changed the title Improve RemoveLoader.scala test coverage Improve RecordLoader.scala test coverage Dec 8, 2017
@greebie
Copy link
Contributor

greebie commented Dec 8, 2017

(RemoveHTML is covered 100%)

@ruebot ruebot closed this as completed Dec 8, 2017
@greebie greebie reopened this Dec 8, 2017
@greebie
Copy link
Contributor

greebie commented Dec 8, 2017

My bad here. The RecordLoader test coverage is not 100%, it's just misnamed. I will try to work on it today.

@greebie greebie mentioned this issue Dec 11, 2017
Merged
@ruebot
Copy link
Member Author

ruebot commented Dec 11, 2017

Partially addressed with: ffb23d8

@ruebot ruebot added the RA-Task label Feb 5, 2018
@ruebot
Copy link
Member Author

ruebot commented Aug 10, 2018

RecordLoader.scala is gone, and integrated elsewhere. Closing this one, and will open up a new ticket.

@ruebot ruebot closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greebie greebie

Labels
RA-Task tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greebie @ruebot