Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct import for WARCConstants; Resolves #127. #133

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Nov 30, 2017

GitHub issue(s): #127

What does this Pull Request do?

Don't use the deprecated WARCConstants.

How should this be tested?

Checkout to TravisCI build output, and the deprecation warning in #127 should be gone.

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #133 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #133   +/-   ##
======================================
  Coverage    65.6%   65.6%           
======================================
  Files          36      36           
  Lines         721     721           
  Branches      140     140           
======================================
  Hits          473     473           
  Misses        199     199           
  Partials       49      49
Impacted Files Coverage Δ
...ava/io/archivesunleashed/data/WarcRecordUtils.java 61.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dbe5ec...c6833ab. Read the comment docs.

Copy link
Member

@ianmilligan1 ianmilligan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me - verified on Travis CI.

@ianmilligan1 ianmilligan1 merged commit be7eeed into master Nov 30, 2017
@ianmilligan1 ianmilligan1 deleted the issue-127 branch November 30, 2017 20:43
ruebot added a commit that referenced this pull request Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants