Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve cobertura-maven-plugin class issue; resolves #313. #314

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

ruebot
Copy link
Member

@ruebot ruebot commented Mar 23, 2019

GitHub issue(s):

What does this Pull Request do?

Exclude slf4j binding logback-classic
(mojohaus/cobertura-maven-plugin#6 (comment))

How should this be tested?

Interested parties

@edsu

@ruebot ruebot requested a review from jrwiebe March 23, 2019 17:35
@ruebot ruebot changed the title Resolve cobertura-maven-plugin class issue; resolves #133. Resolve cobertura-maven-plugin class issue; resolves #313. Mar 23, 2019
@ruebot
Copy link
Member Author

ruebot commented Mar 23, 2019

🤦‍♂️
I messed up the issue number in my original commit message. @jrwiebe if this gets merged, can you make sure the commit message in the GitHub interface is #313 instead of #133?

...or I can amend and force push 🤷‍♂️

@codecov-io
Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   75.84%   75.84%           
=======================================
  Files          41       41           
  Lines        1151     1151           
  Branches      202      202           
=======================================
  Hits          873      873           
  Misses        209      209           
  Partials       69       69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a649e7...4023f62. Read the comment docs.

@jrwiebe jrwiebe merged commit 8504190 into master Mar 23, 2019
@ruebot ruebot deleted the issue-313-detroit branch March 23, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants