-
-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Object Spreading for Transformed Subscription Results #928
Conversation
@ericlewis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
I think it particularly fails when arrays are being returned, good catch 👍 |
Also fails when strings are return. Converts the string to an object, then spits out "[Object object]" as the result. |
This is a blocker for our team! Eagerly waiting for merge and release :) |
I am blocked on using Subscriptions because of the object spreading issue. If some other groundwork needs to be done to facilitate this merge, I am all for contributing. Let me know if you need any help :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes! Sorry this has sat for so long. Thanks for addressing this @ericlewis!
Object spreading causes nothing to be returned when using subscriptions, removing object spreading allows subscriptions to successfully pass their resolutions.