Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Object Spreading for Transformed Subscription Results #928

Merged
merged 4 commits into from
Sep 7, 2018

Conversation

ericlewis
Copy link
Contributor

@ericlewis ericlewis commented Aug 14, 2018

Object spreading causes nothing to be returned when using subscriptions, removing object spreading allows subscriptions to successfully pass their resolutions.

@apollo-cla
Copy link

@ericlewis: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the bug label Aug 14, 2018
@dh94
Copy link
Contributor

dh94 commented Aug 17, 2018

I think it particularly fails when arrays are being returned, good catch 👍

@ericlewis
Copy link
Contributor Author

Also fails when strings are return. Converts the string to an object, then spits out "[Object object]" as the result.

@coco98
Copy link

coco98 commented Aug 24, 2018

This is a blocker for our team! Eagerly waiting for merge and release :)

@wawhal
Copy link

wawhal commented Aug 29, 2018

I am blocked on using Subscriptions because of the object spreading issue.
An update on the estimated time of merge will be really helpful @stubailo

If some other groundwork needs to be done to facilitate this merge, I am all for contributing. Let me know if you need any help :-)

Copy link
Contributor

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes! Sorry this has sat for so long. Thanks for addressing this @ericlewis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants