fix: delegate - data does not exist in value #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikolasburk @schickling this looks like a pretty clear-cut bug and fix IMO, any chance this could be landed & patched? It's a blocking issue for my team. |
|
Thanks for this, I reported this in #153 and this fixes that issue! |
Closed
|
Thanks a lot for this PR, we'll review this soon 👍 |
|
@sheepsteak : Thanks for the PR. Looks good to me 👍 |
|
This is released in Used by |
|
yeah guy finally it's released..., i spent more than one week to figure out this problem (i thought was from my implementation) ... subscriptions who does not work is very pity for prisma... Do you test your api properly before to get out a update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use subscriptions through a GraphQL binding I kept getting an error that
'data' was undefined. After some debugging I found thatvaluedoes not havedataproperty inside it that thedelegateSubscriptionfunction was relying on.I found that the
dataproperty is already extracted in thepushValuefunction of apollographql/graphql-tools. So whatever gets returned on line 87 is already the contents ofdata.With the small change in this PR and the fix in ardatan/graphql-tools#928 I was able to get subscriptions working from my GraphQL server talking to a Hasura GraphQL server via a binding.