test: wait longer after repo server restarted to avoid errors on s390x #12839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Ding <samding@ca.ibm.com>
jannfis
reviewed
Mar 13, 2023
| @@ -811,6 +811,8 @@ func RestartRepoServer() { | |||
| } | |||
| FailOnErr(Run("", "kubectl", "rollout", "restart", "deployment", workload)) | |||
| FailOnErr(Run("", "kubectl", "rollout", "status", "deployment", workload)) | |||
There was a problem hiding this comment.
The rollout status should already wait until a workload is available. I think we should really avoid using introducing newSleep calls with a fixed time length.
Why is this only needed on s390x?
There was a problem hiding this comment.
See http://pastebin.test.redhat.com/1094074 for failed cases log, on s390x the rollout status does not wait enough longer, and causes the follow calling to argocd repo server failed
|
/cherry-pick release-2.4 |
|
/cherry-pick release-2.5 |
|
/cherry-pick release-2.6 |
jannfis
changed the title
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
#12839) Signed-off-by: Sam Ding <samding@ca.ibm.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
#12839) Signed-off-by: Sam Ding <samding@ca.ibm.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
#12839) Signed-off-by: Sam Ding <samding@ca.ibm.com>
alexec
pushed a commit
to alexec/argo-cd
that referenced
this pull request
Mar 19, 2023
argoproj#12839) Signed-off-by: Sam Ding <samding@ca.ibm.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
argoproj#12839) Signed-off-by: Sam Ding <samding@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wait time 10 seconds after
repo serveris restarted to avoidconnection refusederror on s380xin the following 7 cases: