Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: wait longer after repo server restarted to avoid errors on s390x #12839

Merged
merged 1 commit into from
Mar 16, 2023
Merged

test: wait longer after repo server restarted to avoid errors on s390x #12839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/e2e/fixture/fixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,8 @@ func RestartRepoServer() {
}
FailOnErr(Run("", "kubectl", "rollout", "restart", "deployment", workload))
FailOnErr(Run("", "kubectl", "rollout", "status", "deployment", workload))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollout status should already wait until a workload is available. I think we should really avoid using introducing newSleep calls with a fixed time length.

Why is this only needed on s390x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See http://pastebin.test.redhat.com/1094074 for failed cases log, on s390x the rollout status does not wait enough longer, and causes the follow calling to argocd repo server failed

// wait longer to avoid error on s390x
time.Sleep(10 * time.Second)
}
}

Expand Down