fix: check err before use schedule and duration

[daengdaengLee]

Fix #19605

I have made some modifications to the related code, though it doesn't fully resolve the issue.
I have made some modifications to resolve the issue.
Previously, schedule and duration were used before checking sErr and dErr, which could result in a nil pointer exception if an error occurred. (use values in line 2433, check error in line 2435)
I have updated the code to check for errors first and use continue if an error is found.

If I've misunderstood something, please let me know in the comments. Thank you! :)

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

Attention: Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@cf498f6). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
server/application/application.go	36.36%	3 Missing and 4 partials ⚠️
controller/sync.go	69.23%	2 Missing and 2 partials ⚠️
cmd/argocd/commands/app.go	66.66%	0 Missing and 2 partials ⚠️
cmd/argocd/commands/projectwindows.go	0.00%	2 Missing ⚠️
pkg/apis/application/v1alpha1/types.go	95.23%	1 Missing and 1 partial ⚠️
server/project/project.go	33.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #20043   +/-   ##
=========================================
  Coverage          ?   55.97%           
=========================================
  Files             ?      322           
  Lines             ?    44759           
  Branches          ?        0           
=========================================
  Hits              ?    25052           
  Misses            ?    17103           
  Partials          ?     2604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blakepettersson]

Hi @daengdaengLee it looks good so far! Can we just verify that this is actually fixed by adding a test case or two to

argo-cd/pkg/apis/application/v1alpha1/types_test.go

Line 1932 in 5f23bb6

func TestSyncWindows_InactiveAllows(t *testing.T) {

?

[daengdaengLee]

Hello, @blakepettersson.

I have added unit tests for the incorrect schedule and duration.
Please check it.

Thank you!

[blakepettersson]

I noticed in the original issue that there are two other places where this is an issue (search for specParser.Parse in types.go. Could you also handle those ones?

[daengdaengLee]

Hello, @blakepettersson.

Thanks for the comment.
I was planning to submit the other parts in a separate PR.
But if that's your preference, I'll handle everything in this PR!

---

I've handled other things too!
Please check the PR.

Thanks!

[blakepettersson]

Looks great, thanks!

[daengdaengLee]

Hello, @blakepettersson.

I rebase the PR to the latest master branch.

How can I get a review for the PR?
Please let me know.

Thanks!

[crenshaw-dev]

Instead of logging errors in types.go (which is kind of a place for utility functions), could you modify both functions to return an error? That way the consumer can handle the error appropriately, either by logging or by returning the error message to the caller (as in the API Server's Sync method).

[daengdaengLee]

Hello, @crenshaw-dev!

• return err when sync window is invalid in types.go
• keep as close to the original behavior as possible where the functions from types.go are used
• add/edit unit tests for functions in types.go

Please check and comment if you think differently.
Thanks!

[crenshaw-dev]

lgtm, thank you!

[crenshaw-dev]

/cherry-pick release-2.13

[crenshaw-dev]

/cherry-pick release-2.12

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 9b11b21f00f006ec5bfca1ff39210e54b65bf4b5 into temp-cherry-pick-963c53-release-2.12

[crenshaw-dev]

@daengdaengLee if you'd like to cherry-pick back to 2.10-2.12, looks that those will require manual PRs.