fix: check err before use schedule and duration (cherry-pick #20043) #20353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* fix: check err before use schedule and duration Signed-off-by: daengdaengLee <gunho1020@gmail.com> * test: add tests for invalid schedule and duration Signed-off-by: daengdaengLee <gunho1020@gmail.com> * feat: change to return error when sync window is invalid Signed-off-by: daengdaengLee <gunho1020@gmail.com> * fix: use assert.Error or assert.NoError Signed-off-by: daengdaengLee <gunho1020@gmail.com> * fix: use require instead of assert Signed-off-by: daengdaengLee <gunho1020@gmail.com> --------- Signed-off-by: daengdaengLee <gunho1020@gmail.com>
crenshaw-dev
approved these changes
Oct 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-2.13 #20353 +/- ##
================================================
- Coverage 55.88% 55.88% -0.01%
================================================
Files 320 320
Lines 44415 44451 +36
================================================
+ Hits 24823 24843 +20
- Misses 17031 17039 +8
- Partials 2561 2569 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix: check err before use schedule and duration (#20043)
Signed-off-by: daengdaengLee gunho1020@gmail.com
Signed-off-by: daengdaengLee gunho1020@gmail.com
Signed-off-by: daengdaengLee gunho1020@gmail.com
Signed-off-by: daengdaengLee gunho1020@gmail.com
Signed-off-by: daengdaengLee gunho1020@gmail.com
Signed-off-by: daengdaengLee gunho1020@gmail.com