Skip to content

Commit

Permalink
feat(argo-rollouts): Allow customizing additional RBAC rules for othe…
Browse files Browse the repository at this point in the history
…r providers (#2556)

* Allow customizing additional RBAC rules for other providers

Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>

* Changing additionalRules from dict to list

Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>

* Changing additionalRules from dict to list and addressing comment

Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>

* Runing `./scripts/helm-docs.sh` to update the README

Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>

---------

Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Co-authored-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
  • Loading branch information
4 people authored Mar 22, 2024
1 parent e248b6b commit 8a4c875
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 12 deletions.
6 changes: 3 additions & 3 deletions charts/argo-rollouts/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v1.6.6
description: A Helm chart for Argo Rollouts
name: argo-rollouts
version: 2.34.3
version: 2.34.4
home: https://github.com/argoproj/argo-helm
icon: https://argoproj.github.io/argo-rollouts/assets/logo.png
keywords:
Expand All @@ -18,5 +18,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Bump argo-rollouts to v1.6.6
- kind: added
description: Allow customizing additional RBAC rules for other providers
1 change: 1 addition & 0 deletions charts/argo-rollouts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ For full list of changes please check ArtifactHub [changelog].
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
| notifications.templates | object | `{}` | Notification templates |
| notifications.triggers | object | `{}` | The trigger defines the condition when the notification should be sent |
| providerRBAC.additionalRules | list | `[]` | Additional RBAC rules for others providers |
| providerRBAC.enabled | bool | `true` | Toggles addition of provider-specific RBAC rules to the controller Role and ClusterRole |
| providerRBAC.providers.ambassador | bool | `true` | Adds RBAC rules for the Ambassador provider |
| providerRBAC.providers.apisix | bool | `true` | Adds RBAC rules for the Apisix provider |
Expand Down
21 changes: 12 additions & 9 deletions charts/argo-rollouts/templates/controller/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -258,23 +258,26 @@ rules:
{{- if .Values.providerRBAC.providers.contour }}
# Access needed when using the Contour provider
- apiGroups:
- projectcontour.io
- projectcontour.io
resources:
- httpproxies
- httpproxies
verbs:
- get
- list
- watch
- update
- get
- list
- watch
- update
{{- end }}
{{- if .Values.providerRBAC.providers.glooPlatform }}
# Access needed when using the Gloo Platform provider
- apiGroups:
- networking.gloo.solo.io
- networking.gloo.solo.io
resources:
- routetables
- routetables
verbs:
- '*'
- '*'
{{- end }}
{{- with .Values.providerRBAC.additionalRules }}
{{ toYaml . }}
{{- end }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/argo-rollouts/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,8 @@ providerRBAC:
contour: true
# -- Adds RBAC rules for the Gloo Platform provider, see `https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-glooplatform/blob/main/README.md`
glooPlatform: true
# -- Additional RBAC rules for others providers
additionalRules: []

dashboard:
# -- Deploy dashboard server
Expand Down

0 comments on commit 8a4c875

Please sign in to comment.