Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-rollouts): Allow customizing additional RBAC rules for other providers #2556

Merged
merged 8 commits into from
Mar 22, 2024

Conversation

amcamina
Copy link
Contributor

@amcamina amcamina commented Feb 29, 2024

Allow customizing additional RBAC rules for other providers

In my case, we used the service mesh LinkerD. However, the helm chart doesn't give any option to add more rules to the ClusterRole.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco
Copy link
Collaborator

Hi @amcamina, thank you for your PR.

Linting and Testing / chart-test (pull_request)

Maybe you should run ./scripts/helm-docs.sh at this repo's root dir to format README.
Ref: https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#documentation

DCO

You can fix with the following.
Ref: https://github.com/argoproj/argo-helm/pull/2556/checks?check_run_id=22126507245

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name authoremail@example.com in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Alvaro.Camina added 4 commits February 29, 2024 15:39
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM.

@amcamina
Copy link
Contributor Author

@jmeridth Could you review this PR?

@jmeridth jmeridth merged commit 8a4c875 into argoproj:main Mar 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants