-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-rollouts): Allow customizing additional RBAC rules for other providers #2556
Conversation
Hi @amcamina, thank you for your PR.
Maybe you should run
You can fix with the following.
|
765363a
to
c2b06ee
Compare
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
Signed-off-by: Alvaro.Camina <alvaro.camina@alteryx.com>
c2b06ee
to
a1f19d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. LGTM.
@jmeridth Could you review this PR? |
Allow customizing additional RBAC rules for other providers
In my case, we used the service mesh LinkerD. However, the helm chart doesn't give any option to add more rules to the
ClusterRole
.Checklist: