Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argocd-apps): Generate application, applicationset, project with template #2025

Merged
merged 16 commits into from
May 19, 2023

Conversation

joelee2012
Copy link
Contributor

@joelee2012 joelee2012 commented May 8, 2023

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@jmeridth jmeridth changed the title [argocd-app] Add templates for application, applicationset, project feat(argocd-app): Add templates for application, applicationset, project May 8, 2023
@jmeridth
Copy link
Member

jmeridth commented May 8, 2023

Please update the annotations for artifacthub at the bottom of the Chart.yaml file. Thank you.

@jmeridth jmeridth changed the title feat(argocd-app): Add templates for application, applicationset, project feat(argocd-apps): Add templates for application, applicationset, project May 8, 2023
charts/argocd-apps/values.yaml Outdated Show resolved Hide resolved
charts/argocd-apps/values.yaml Outdated Show resolved Hide resolved
charts/argocd-apps/ci/application-templates.yaml Outdated Show resolved Hide resolved
@joelee2012 joelee2012 changed the title feat(argocd-apps): Add templates for application, applicationset, project feat(argocd-apps): Generate application, applicationset, project with template May 8, 2023
@github-actions github-actions bot added size/L and removed size/M labels May 8, 2023
@joelee2012
Copy link
Contributor Author

Please update the annotations for artifacthub at the bottom of the Chart.yaml file. Thank you.

sure

@jmeridth
Copy link
Member

jmeridth commented May 9, 2023

You need to update the documentation with your new itemTemplates

@joelee2012
Copy link
Contributor Author

You need to update the documentation with your new itemTemplates

updated

@joelee2012
Copy link
Contributor Author

@jmeridth is it possible to enable all testing for PR by default ? so that the owner can fix every issue before requiring code review. how do you think ?

@jmeridth
Copy link
Member

jmeridth commented May 9, 2023

@joelee2012 that's fine. Your update doc commit is not signed. Can't pass DCO.

@joelee2012
Copy link
Contributor Author

@jmeridth btw, should i update version to 1.1.0 instead of 1.0.1 as it's new feature ?

@joelee2012
Copy link
Contributor Author

@jmeridth @mkilchhofer are you able check again ?

Copy link
Contributor Author

@joelee2012 joelee2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@joelee2012
Copy link
Contributor Author

@mkilchhofer are you able to check again ?

Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
Signed-off-by: Joe Lee <lj_2005@163.com>
@joelee2012
Copy link
Contributor Author

@mkilchhofer can you help review again ?

@mkilchhofer mkilchhofer merged commit c3cfd49 into argoproj:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants