-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argocd-apps)!: use maps instead of lists #2538
Conversation
Signed-off-by: irizzant <i.rizzante@gmail.com>
Signed-off-by: irizzant <i.rizzante@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: irizzant <i.rizzante@gmail.com>
@mkilchhofer Looks good but wondering one thing:
|
Signed-off-by: irizzant <i.rizzante@gmail.com>
@jmeridth I updated the manifests to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple questions
Signed-off-by: irizzant <i.rizzante@gmail.com>
Signed-off-by: irizzant <i.rizzante@gmail.com>
Any news ? |
@mkilchhofer |
@jmeridth is this on my end? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didnt use the range function properly on all implemented resources.
$ helm template apps .
Error: parse error at (argocd-apps/templates/projects.yaml:1): range can only initialize variables
I fixed the project.yaml and run template again, then:
$ helm template apps .
Error: parse error at (argocd-apps/templates/item-templates.yaml:1): function "_" not defined
Use --debug flag to render out invalid YAML
I try to fix them
I reverted the changes on the Can you live with this @irizzant ? IMHO it is too complex to refactor this feature. |
…lates) Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚀
@mkilchhofer thank you for the refactoring. |
This PR fixes #2523
Checklist: