fix(argo-workflows): Fix trailing whitespace in controller ConfigMap #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two places where trailing whitespace may be generated in the workflow-controller ConfigMap. When the value `.resourceRateLimit` is not null, a trailing whitespace is added after "resourceRateLimit:". This commit trims that whitespace. When the value `.sso.redirectUrl` is left as the default of empty string, a trailing whitespace is left after "redirectUrl:" as this value is not quoted. This commit pipes this value through `quote` to ensure this whitespace is no longer trailing and instead followed by `"` pair. The main motivation of this commit is to generate a workflow-controller ConfigMap that is properly pretty-printed, which trailing whitespace prevents. Signed-off-by: James Slater <SlaterByte@users.noreply.github.com>
SlaterByte
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
yu-croco
approved these changes
Jan 24, 2024
pdrastil
added a commit
to pdrastil/argo-helm
that referenced
this pull request
Jan 30, 2024
* pdrastil/main: fix(argo-cd): Restart argocd-server when argocd-cm CM is updated (argoproj#2459) chore(deps): bump tj-actions/changed-files from 42.0.0 to 42.0.2 (argoproj#2458) chore(deps): bump actions/upload-artifact from 4.2.0 to 4.3.0 (argoproj#2457) docs(argo-workflows): Add MySQL persistence support explicitly on README (argoproj#2448) fix(argo-cd): Fix Repo server `serviceaccount` label template (argoproj#2454) chore(argo-rollouts): Update dependency argoproj/argo-rollouts to v1.6.5 (argoproj#2453) docs(argocd-apps): Add deprecated note for Argo CD Extensions (argoproj#2449) fix(argo-workflows): Fix trailing whitespace in controller ConfigMap (argoproj#2451)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two places where trailing whitespace may be generated in the workflow-controller ConfigMap.
When the value
.resourceRateLimitis not null, a trailing whitespace is added after "resourceRateLimit:". This commit trims that whitespace.When the value
.sso.redirectUrlis left as the default of empty string, a trailing whitespace is left after "redirectUrl:" as this value is not quoted. This commit pipes this value throughquoteto ensure this whitespace is no longer trailing and instead followed by"pair.The main motivation of this commit is to generate a workflow-controller ConfigMap that is properly pretty-printed, which trailing whitespace prevents.
Checklist: