Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-workflows): Fix trailing whitespace in controller ConfigMap #2451

Merged
merged 1 commit into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. fix(argo-workflows): Fix trailing whitespace in controller ConfigMap

    This commit addresses two places where trailing whitespace may be
    generated in the workflow-controller ConfigMap.
    
    When the value `.resourceRateLimit` is not null, a trailing whitespace
    is added after "resourceRateLimit:". This commit trims that whitespace.
    
    When the value `.sso.redirectUrl` is left as the default of empty string,
    a trailing whitespace is left after "redirectUrl:" as this value is not
    quoted. This commit pipes this value through `quote` to ensure this
    whitespace is no longer trailing and instead followed by `"` pair.
    
    The main motivation of this commit is to generate a workflow-controller
    ConfigMap that is properly pretty-printed, which trailing whitespace
    prevents.
    
    Signed-off-by: James Slater <SlaterByte@users.noreply.github.com>
    SlaterByte committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3cb8736 View commit details
    Browse the repository at this point in the history