Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-workflows): Added support for setting annotations on argo workflows controller configmap #2889

Merged
merged 1 commit into from
Aug 20, 2024
Merged

feat(argo-workflows): Added support for setting annotations on argo workflows controller configmap #2889

merged 1 commit into from
Aug 20, 2024

Conversation

bdun1013
Copy link
Contributor

@bdun1013 bdun1013 commented Aug 20, 2024 •
edited
Loading

Closes #2888

Added support for setting annotations on argo workflows controller configmap

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@bdun1013 bdun1013 changed the title Added support for setting annotations on argo workflows controller configmap feat(argo-workflows): Added support for setting annotations on argo workflows controller configmap Aug 20, 2024
@bdun1013
argoproj#2888 Added support for setting annotations on argo workflows…
1185e9e 
… controller configmap

Signed-off-by: Brian Dunnigan <bdunnigan@clarityinnovates.com>
@bdun1013 bdun1013 force-pushed the 2888-argo-workflows-controller-configmap-annotations branch from 6fde183 to 1185e9e Compare August 20, 2024 16:46
@bdun1013 bdun1013 marked this pull request as ready for review August 20, 2024 16:47
vladlosev
vladlosev approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@vladlosev vladlosev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdun1013 bdun1013 mentioned this pull request Aug 20, 2024
Closed
6 tasks
@tico24 tico24 merged commit 8c0b686 into argoproj:main Aug 20, 2024
9 checks passed
@bdun1013 bdun1013 deleted the 2888-argo-workflows-controller-configmap-annotations branch August 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico24 tico24 tico24 approved these changes

@vladlosev vladlosev vladlosev approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@yu-croco yu-croco Awaiting requested review from yu-croco yu-croco is a code owner

Assignees
No one assigned
Labels
argo-workflows size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting annotations in argo-workflows controller configmap
3 participants
@bdun1013 @vladlosev @tico24