Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-workflows): Added configmap checksum annotation to restart Deployments on ConfigMap update #2891

Conversation

bdun1013
Copy link
Contributor

@bdun1013 bdun1013 commented Aug 20, 2024

Added configmap checksum annotation to restart Deployments on ConfigMap update

Closes #2890

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@bdun1013 bdun1013 changed the title #2890 Added configmap checksum annotation to restart Deployments on ConfigMap update feat(argo-workflows): Added configmap checksum annotation to restart Deployments on ConfigMap update Aug 20, 2024
…nts on ConfigMap update

Signed-off-by: Brian Dunnigan <bdunnigan@clarityinnovates.com>
@bdun1013 bdun1013 force-pushed the 2890-argo-workflows-configmap-checksum branch from b7e5de3 to f4fc529 Compare August 20, 2024 17:50
@bdun1013 bdun1013 marked this pull request as ready for review August 20, 2024 17:51
@vladlosev
Copy link
Collaborator

With support for custom annotations on config maps, I would rather have it achieved with the support from a service like Reloader.

@bdun1013
Copy link
Contributor Author

With support for custom annotations on config maps, I would rather have it achieved with the support from a service like Reloader.

Works for me! That was my intention with #2889. I will close this PR.

@bdun1013 bdun1013 closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reloading argo workflows Deployments when ConfigMap changes
2 participants