-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: log rs name when update fails #3318
Conversation
Go Published Test Results2 093 tests 2 093 ✅ 2m 49s ⏱️ Results for commit c3e3421. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3318 +/- ##
=======================================
Coverage 81.83% 81.83%
=======================================
Files 135 135
Lines 20633 20633
=======================================
Hits 16885 16885
Misses 2877 2877
Partials 871 871 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 26m 38s ⏱️ For more details on these failures, see this check. Results for commit c3e3421. ♻️ This comment has been updated with latest results. |
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
e9ee20c
to
c3e3421
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix logging rs name when update fails Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
don't log an empty rs.Name because when we error out we end up getting a defaulted replicaset.