Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log rs name when update fails #3318

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

zachaller
Copy link
Collaborator

don't log an empty rs.Name because when we error out we end up getting a defaulted replicaset.

@zachaller zachaller changed the title fix logging rs name when update fails fix: logging rs name when update fails Jan 18, 2024
@zachaller zachaller changed the title fix: logging rs name when update fails fix: log rs name when update fails Jan 18, 2024
Copy link
Contributor

github-actions bot commented Jan 18, 2024

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit c3e3421.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (31fe59b) 81.83% compared to head (c3e3421) 81.83%.
Report is 2 commits behind head on master.

Files Patch % Lines
rollout/sync.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3318   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         135      135           
  Lines       20633    20633           
=======================================
  Hits        16885    16885           
  Misses       2877     2877           
  Partials      871      871           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 26m 38s ⏱️
106 tests  96 ✅  6 💤 4 ❌
432 runs  400 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit c3e3421.

♻️ This comment has been updated with latest results.

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller force-pushed the fix-logging-rs-name branch from e9ee20c to c3e3421 Compare January 22, 2024 16:52
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 6dd961a into argoproj:master Jan 25, 2024
22 of 23 checks passed
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Jan 25, 2024
zachaller added a commit that referenced this pull request Jan 25, 2024
fix logging rs name when update fails

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.6 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants