UI: links for label containing dot not working

[tooptoop4]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

using links: in wfcontroller configmap:

for a label key not containing slash it works, ie this works:
label=s3-folder%3D${workflow.metadata.labels.s3-folder}

for a label key containing dot slash it returns null in the generated link url:
label=workflows.argoproj.io%2Fworkflow-template%3D${workflow.metadata.labels.workflows.argoproj.io/workflow-template}
below also returns null
label=workflows.argoproj.io%2Fworkflow-template%3D${workflow.metadata.labels.workflows.argoproj.io%2Fworkflow-template}

Version

3.4.8

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

n/a

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[agilgur5]

If this is a UI-only error, this function may need updating to handle this.

Is it slashes specifically that fail, or the fact that the label has dots in it?
This line in the example configmap works, but that's a static link, not a templated link

[tooptoop4]

my guess is that it doesn't know how to reference label key with dot because it might be searching for a key of 'workflows'

[agilgur5]

Yes, that's what I was referring to.

On more detailed investigation, it's definitely the dot. It's used as a delimiter. The slash shouldn't matter since it uses bracket notation.

This would need a more complicated regex to solve. Either the user input would have to be in bracket notation or could specifically check for labels and annotations and stop delimiting if those are reached. Bracket notation would be more consistent with expr on the backend and JS bracket notation, so I'd probably opt for that. Although stopping delimiting would be simpler 🤔
We'd need a new example for the docs of this as well. And tests for this case would be good to add too.

[tooptoop4]

i tried bracket notation but still no luck

[agilgur5]

Correct, it is not currently supported. That was just one option / proposal I wrote if a fix were to be implemented.

[agilgur5]

Oh right, figured I'd mention that the workaround would be to not use a dot in the label.

[tooptoop4]

maybe #13752 will help

[BojanZelic]

it seems like with the merged PR there would still be an issue getting labels/annotations from podMetadata

ex:

${workflow.spec.podMetadata.annotations.workflows.argoproj.io/something}

wouldn't work because the logic is only limited to workflow.metadata.labels or workflow.metadata.annotations