refactor(ui): optimize Link functionality #11743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move static functions outside of the component
- this way they are not created every time the component is and hence use less memory etc
- use named `function`s instead of `const`s assigned to anonymous functions
- this makes tracing a bit easier and source maps a bit clearer
- (also technically a memory improvement as well)
- re-use `openLinkWithKey` in `WorkflowDetails` instead of having duplicate code
- rename to `openLinkWithKey` so that it doesn't overlap with `openLink` and to be a bit more specific
- (also a very tiny memory improvement)
- remove redundant `formatURL` function
- use lowercase "p" in `processURL`
- JS convention that only classes are capitalized (or components in React, which used to always be classes)
- I imagine this might have been capitalized b/c Go uses capitals for exports?
- be more specific with `urlExpression` as the argument since it is not necessarily a raw URL and that is why it needs "processing"
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
This was referenced Sep 9, 2023
isubasinghe
approved these changes
Sep 15, 2023
I wrote this a few weeks ago, but it's quite literal, since it's when clicked with |
Correct. I didn't say it did. Per the opening comment, this was an incidental finding while I was investigating that |
terrytangyuan
approved these changes
Sep 28, 2023
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
auto-merge was automatically disabled
September 29, 2023 00:36
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
linksmodule and its usage a bitStumbled upon this while investigating #11741 and thought it could use some improvements
Modifications
move static functions outside of the component
use named
functions instead ofconsts assigned to anonymous functionsboth of these also reduce nesting
re-use
openLinkWithKeyinWorkflowDetailsinstead of having duplicate codeopenLinkWithKeyso that it doesn't overlap withopenLinkand to be a bit more specificremove redundant
formatURLfunctionuse lowercase "p" in
processURLbe more specific with
urlExpressionas the argument since it is not necessarily a raw URL and that is why it needs "processing"Verification
Stylistic and performance changes, but no usage changes (minor semantic differences that improve tracing, memory, etc as mentioned above, but do not change usage).