Regression: ARGO_BASE_HREF env var doesn't work

[rijos]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug

What happened/what you expected to happen?

It seems the name change from BASE_HREF to ARGO_BASE_HREF breaks base href functionality.

Here is my deployment:

Here is the html output:

Server logs:

Version

v3.5.7

[agilgur5]

It seems the name change from BASE_HREF to ARGO_BASE_HREF breaks base href functionality

Er, #12653 is not part of any stable release and its upgrade notes are for 3.6, which you aren't on.

Version

v3.5.7

• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.

And this should work on :latest. Are you sure you tested with :latest as the issue template requires?

Here is my deployment:

Also please use text instead of images of code or logs; text is substantially more accessible

[agilgur5]

It sounds like there might be a regression in the Helm chart though (did you mean to file an issue in that repo?), as I wrote up argoproj/argo-helm#2756 for forward-compat, but failed to read my own release notes 4 months later that the missing dash (--basehref) means it won't work. I'll fix that ASAP

[agilgur5]

It sounds like there might be a regression in the Helm chart though [...] I'll fix that ASAP

Done: argoproj/argo-helm#2770

My bad on that Helm regression 😖