Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-workflows): BASE_HREF -> ARGO_BASE_HREF for forward compat #2756

Merged
merged 1 commit into from
Jun 9, 2024
Merged

fix(argo-workflows): BASE_HREF -> ARGO_BASE_HREF for forward compat #2756

merged 1 commit into from
Jun 9, 2024

Conversation

agilgur5
Copy link
Member

@agilgur5 agilgur5 commented Jun 9, 2024 •
edited
Loading

Summary

BASE_HREF is redundant and will be removed in a future release (see argoproj/argo-workflows#12653), so move to the existing ARGO_BASE_HREF for forward compat

Details

Checklist:

  • I have bumped the chart version according to versioning
  • [n/a] I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • [n/a] Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@agilgur5
fix(argo-workflows): BASE_HREF -> ARGO_BASE_HREF for forward compat
134cecd 
- `BASE_HREF` is redundant and will be removed in a future release, so move to `ARGO_BASE_HREF` for forward compat

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 mentioned this pull request Jun 9, 2024
Merged
yu-croco
yu-croco approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@yu-croco yu-croco merged commit 8b02b6d into argoproj:main Jun 9, 2024
7 checks passed
@agilgur5 agilgur5 deleted the fix-workflows-base-href-env branch June 10, 2024 00:49
This was referenced Jun 17, 2024
Closed
Merged
@agilgur5
Copy link
Member Author

agilgur5 commented Jun 17, 2024 •
edited
Loading

Sorry folks, I screwed this up and didn't re-read my own release notes 😞
There is no forward compatible change, which is probably why I didn't make this PR earlier 🤦

Tried to be proactive and instead caused a regression 😐

Reverted this in #2770 -- also more details there

@rijos
Copy link

rijos commented Jun 17, 2024

@agilgur5
Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeridth jmeridth jmeridth approved these changes

@yu-croco yu-croco yu-croco approved these changes

@vladlosev vladlosev Awaiting requested review from vladlosev vladlosev is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-workflows size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agilgur5 @rijos @jmeridth @yu-croco