fix(argo-workflows): revert BASE_HREF change
#2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2024 13:40
This reverts commit 134cecd. Sorry, I screwed up this and caused a regression. Didn't read my own release notes (from 4 months ago to be fair) where `ARGO_BASE_HREF` would not work previously as it was inconsistently `ARGO_BASEHREF`. So there is no forward compatible change to be made here, so just revert this. Will have to reinstate this change for the 3.6 upgrade Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
tico24
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts my own #2756
Fixes argoproj/argo-workflows#13199 (comment)
Sorry, I screwed this up and caused a regression. Didn't re-read my own release notes from argoproj/argo-workflows#12653 (I wrote them 4 months ago to be fair) where
ARGO_BASE_HREFwould not work previously as it was inconsistentlyARGO_BASEHREF(missing an underscore as the flag was missing a dash--basehref).So there is actually no forward compatible change possible, and as such, just revert #2756.
I probably realized this when I wrote argoproj/argo-workflows#12653 (comment) and didn't make a PR downstream here at the time (or earlier, when I first wrote the PR) and then forgot about that 4 months later (once I had approvals to merge).
That's my bad, sorry; I was trying to be proactive and instead caused a regression 😞
Note that we will have to reinstate this change when it comes time to make the 3.6 upgrade
Checklist: