-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timezone support to CronWorkflows #1931
Comments
Update: I've come up with a design to add timezone support and will implement it after the upcoming API Server release |
Hey @simster7 , am I right thinking this is quite easy to implement ? Being more and more involved into K8S stuff, I am willing to get my hands dirty with some work using Golang, and why not this feature implementation. What do you think about it ? If you agree, I would be glad to hear about the design you came up with. |
Sure! New contributors are always welcome. The design is simple: The library we use to dispatch Docs: https://godoc.org/github.com/robfig/cron#hdr-Time_zones P.S. I suggest starting this after #1882 is merged in, since that also contains some changes to |
@rdigiorgio Sorry, I had to take over this PR since I realized that more involved changes would be needed (such as adding timezone binaries to our images). If you're still interested in contributing feel free to checkout our help wanted and good first issue tags! I'll be adding more items to these soon |
Ok @simster7 , I started working on it, but I do not think it will help you much making a PR for you to see the changes as it really was simple |
Users have requested timezone support to CronWorkflows
Originally posted by @evaneaston in #1758 (comment)
Originally posted by @rdigiorgio in #1758 (comment)
The text was updated successfully, but these errors were encountered: