Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cron): Added timezone support to cron workflows. Closes #1931 #1986

Merged
merged 6 commits into from
Jan 16, 2020

Conversation

simster7
Copy link
Member

Closes: #1931

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@simster7 simster7 changed the title feat: Added timezone support to CronWorkflows #1978 feat: Added timezone support to CronWorkflows Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #1986 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1986      +/-   ##
=========================================
- Coverage    8.88%   8.87%   -0.02%     
=========================================
  Files          53      53              
  Lines       33608   33647      +39     
=========================================
  Hits         2985    2985              
- Misses      30233   30272      +39     
  Partials      390     390
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/openapi_generated.go 0% <0%> (ø) ⬆️
pkg/apis/workflow/v1alpha1/generated.pb.go 0.45% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d5803...27f59dc. Read the comment docs.

@alexec alexec changed the title feat: Added timezone support to CronWorkflows feat(cron): Added timezone support to cron workflows. Closes #1931 Jan 16, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval, conditions:

  1. Please can you make it clear to users what the default is.
  2. This is consistent with K8S Crons as per https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/

pkg/apis/workflow/v1alpha1/cron_workflow_types.go Outdated Show resolved Hide resolved
test/e2e/cron_test.go Show resolved Hide resolved
@simster7 simster7 merged commit 1a777cc into argoproj:master Jan 16, 2020
@simster7 simster7 deleted the cron-tz-master branch January 16, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timezone support to CronWorkflows
2 participants