Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-submitted workflows do not carry over labels #3622

Closed
alexec opened this issue Jul 28, 2020 · 2 comments · Fixed by #3638
Closed

Re-submitted workflows do not carry over labels #3622

alexec opened this issue Jul 28, 2020 · 2 comments · Fixed by #3638
Labels
type/bug

Comments

@alexec
Copy link
Contributor

alexec commented Jul 28, 2020

When you re-submit a workflow, labels for templates should remain?

workflows.argoproj.io/resubmitted-from-workflow
@jessesuen
Copy link
Member

I agree we should carry forward existing labels (aside from the ones used functionally e.g. completed=true)

@jessesuen jessesuen changed the title Re-submitted. workflows do not honor labels Re-submitted workflows do not carry over labels Jul 29, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue Jul 29, 2020
@alexec
fix(controller): Carry-over labels for re-submitted workflows. Fixes a…
78eae5e 
…rgoproj#3622
@alexec alexec mentioned this issue Jul 29, 2020
Merged
6 tasks
alexec added a commit that referenced this issue Jul 30, 2020
@alexec
fix(controller): Carry-over labels for re-submitted workflows. Fixes #…
f77780f 
…3622 (#3638)
alexec added a commit that referenced this issue Aug 11, 2020
@alexec
fix(controller): Carry-over labels for re-submitted workflows. Fixes #…
fe8129c 
…3622 (#3638)
@alexec
Copy link
Contributor Author

alexec commented Aug 14, 2020

Available in v2.10.0-rc7.

@yoichiwo7 yoichiwo7 mentioned this issue Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): Carry-over labels for re-submitted workflows. Fixes #3622 alexec/argo-workflows
3 participants
@alexec @jessesuen @sarabala1979