Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Carry-over labels for re-submitted workflows. Fixes #3622 #3638

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix(controller): Carry-over labels for re-submitted workflows. Fixes #3622 #3638

merged 1 commit into from
Jul 30, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jul 29, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Fixes #3622

@alexec alexec marked this pull request as ready for review July 29, 2020 21:12
@sarabala1979 sarabala1979 self-assigned this Jul 29, 2020
terrytangyuan
terrytangyuan approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@alexec alexec merged commit f77780f into argoproj:master Jul 30, 2020
@alexec alexec deleted the fix-3622 branch July 30, 2020 16:28
alexec added a commit that referenced this pull request Aug 11, 2020
@alexec
fix(controller): Carry-over labels for re-submitted workflows. Fixes #…
fe8129c 
…3622 (#3638)
@alexec
Copy link
Contributor Author

alexec commented Aug 14, 2020

Available in v2.10.0-rc7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-submitted workflows do not carry over labels
3 participants
@alexec @terrytangyuan @sarabala1979