Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Golang 1.16 #5563

Closed
alexec opened this issue Mar 31, 2021 · 0 comments · Fixed by #6471
Closed

Upgrade to Golang 1.16 #5563

alexec opened this issue Mar 31, 2021 · 0 comments · Fixed by #6471
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Milestone
2021 Q3

Comments

@alexec
Copy link
Contributor

alexec commented Mar 31, 2021 •
edited by agilgur5
Loading

golang/go#39568

GODEBUG is removed in Golang 1.16, so we may need to find a solution to this.
@alexec alexec added the type/feature Feature request label Mar 31, 2021
@alexec alexec added this to the v3.2 milestone Apr 20, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Apr 20, 2021
@alexec
feat: Upgrade to Go 16. Closes argoproj#5563'
159db5e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked a pull request Apr 20, 2021 that will close this issue
feat: Upgrade to Go 1.16. Closes #5563 #5721
Closed
@alexec alexec mentioned this issue Apr 23, 2021
Closed
@alexec alexec modified the milestones: v3.2, v3.3 May 10, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Aug 2, 2021
@alexec
feat!: Upgrade to Golang 1.16. Fixes argoproj#5563
b1f1d07 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Aug 2, 2021
Merged
alexec added a commit that referenced this issue Aug 3, 2021
@alexec
feat!: Upgrade to Golang 1.16. Fixes #5563 (#6471)
7f2c589 
* feat!: Upgrade to Golang 1.16. Fixes #5563

Signed-off-by: Alex Collins <alex_collins@intuit.com>

* make lint

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Aug 11, 2021
Closed
28 tasks
@alexec alexec modified the milestones: v3.3, v3.2 Oct 5, 2021
@alexec alexec mentioned this issue Oct 8, 2021
Merged
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Oct 20, 2023
@agilgur5 agilgur5 changed the title Upgrade to Golang 16 Upgrade to Golang 1.16 Oct 16, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Projects
None yet
Milestone
2021 Q3
2 participants
@alexec @agilgur5