Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simplify using Golang 1.16 #6893

Merged
merged 4 commits into from
Oct 8, 2021
Merged

build: simplify using Golang 1.16 #6893

merged 4 commits into from
Oct 8, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 8, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
See #6890
See #5563

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #6893 (04d4d63) into master (ef6aad6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6893   +/-   ##
=======================================
  Coverage   48.49%   48.50%           
=======================================
  Files         265      265           
  Lines       19258    19259    +1     
=======================================
+ Hits         9340     9342    +2     
  Misses       8865     8865           
+ Partials     1053     1052    -1     
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
workflow/controller/operator.go 71.06% <0.00%> (-0.15%) ⬇️
workflow/util/util.go 45.78% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6aad6...04d4d63. Read the comment docs.

@alexec
Copy link
Contributor Author

alexec commented Oct 8, 2021

bash: /home/runner/go/pkg/mod/k8s.io/code-generator@v0.21.5/generate-groups.sh: No such file or directory

Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added 2 commits October 8, 2021 09:11
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review October 8, 2021 16:32
@alexec alexec merged commit 606011b into master Oct 8, 2021
@alexec alexec deleted the tmp branch October 8, 2021 16:49
This was referenced Oct 15, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tech debug: migrate tooling to take advantage of Go 1.16 Make it easier to “make pre-commit”
2 participants