Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech debt: Move ui pod name functions to separate file and add tests #6946

Closed
JPZ13 opened this issue Oct 15, 2021 · 0 comments · Fixed by #6954
Closed

tech debt: Move ui pod name functions to separate file and add tests #6946

JPZ13 opened this issue Oct 15, 2021 · 0 comments · Fixed by #6954
Labels
type/feature Feature request

Comments

@JPZ13
Copy link
Member

JPZ13 commented Oct 15, 2021

In #6925, @alexec requested that we make the following changes in the ui:

  • factor out the pod name functions into a separate file
  • add tests for those functions
@JPZ13 JPZ13 added the type/feature Feature request label Oct 15, 2021
This was referenced Oct 15, 2021
Merged
Merged
alexec pushed a commit that referenced this issue Oct 18, 2021
@JPZ13
chore(ui): Move pod name functions and add tests. Fixes #6946 (#6954)
1239ba8 
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Oct 21, 2021
Closed
24 tasks
sarabala1979 pushed a commit that referenced this issue Oct 21, 2021
@JPZ13 @sarabala1979
chore(ui): Move pod name functions and add tests. Fixes #6946 (#6954)
99d1109 
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this issue Oct 24, 2021
@JPZ13 @kriti-sc
chore(ui): Move pod name functions and add tests. Fixes argoproj#6946 (…
01e80de 
…argoproj#6954)

Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ui): Move pod name functions and add tests. Fixes #6946 JPZ13/argo-workflows
1 participant
@JPZ13