fix(ui): Change pod names to new format. Fixes #6865 #6925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6925 +/- ##
==========================================
- Coverage 48.56% 48.55% -0.02%
==========================================
Files 265 265
Lines 19263 19260 -3
==========================================
- Hits 9356 9352 -4
- Misses 8855 8857 +2
+ Partials 1052 1051 -1
Continue to review full report at Codecov.
|
ui/src/app/shared/utils.ts
Outdated
|
|
||
| // getPodName returns a deterministic pod name | ||
| getPodName(workflowName: string, nodeName: string, templateName: string, nodeID: string): string { | ||
| if (process.env.POD_NAMES === 'v1') { |
There was a problem hiding this comment.
does this work when we've baked the image? I don't think there is an env? I'm not sure how we solve the configuration problem without providing an API, and I don't want to provide an API as it's meant to be emergency use only
There was a problem hiding this comment.
I'm not sure - I haven't spent any time looking at the UI build process. In the meantime, I removed the env reference
| @@ -117,5 +120,46 @@ export const Utils = { | |||
| // return a namespace, never return null/undefined, defaults to "default" | |||
| getNamespaceWithDefault(namespace: string) { | |||
| return this.managedNamespace || namespace || this.currentNamespace || 'default'; | |||
| }, | |||
|
|
|||
| ensurePodNamePrefixLength(prefix: string): string { | |||
There was a problem hiding this comment.
I'd be tempted to put these into their own file, maybe add tests. I think that work could be done as tech debt.
Certainly. I made the tech debt issue at #6946. Feel free to assign it to me, and I can most likely knock it out next week once I return home from traveling |
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
Signed-off-by: J.P. Zivalich <j.p.zivalich@gmail.com>
JPZ13
force-pushed
the
fix-ui-pod-logs
branch
from
dfdbcf0 to
3b4cab8
Compare
…j#6925) Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Signed-off-by: J.P. Zivalich j.p.zivalich@gmail.com
This PR: