Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): use podname for EventPanel name param (#10051) #10052

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix(ui): use podname for EventPanel name param (#10051) #10052

merged 1 commit into from
Nov 18, 2022

Conversation

fsiegmund
Copy link
Contributor

Signed-off-by: fsiegmund siegmund@slb.com

Fixes #10051

@fsiegmund
fix(ui): use podname for EventPanel name param (argoproj#10051)
84c6619 
Signed-off-by: fsiegmund <siegmund@slb.com>
@fsiegmund fsiegmund marked this pull request as ready for review November 17, 2022 12:01
@fsiegmund
Copy link
Contributor Author

Fix is in addition to #6925

tczhao
tczhao approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(note: the bug was due podname v2, nodeid used to be same as podname)

@terrytangyuan terrytangyuan merged commit 74766d5 into argoproj:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event viewer UI not showing events for retriable worksteps
3 participants
@fsiegmund @terrytangyuan @tczhao