Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump swagger-ui-react from 4.12.0 to 5.1.3 in /ui #11418

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 22, 2023

Bumps swagger-ui-react from 4.12.0 to 5.1.3.

Release notes

Sourced from swagger-ui-react's releases.

Swagger UI v5.1.3 Released!

5.1.3 (2023-07-18)

Bug Fixes

  • docker: fix libtiff NULL Pointer dereference issue (#9034) (58f83b6)
  • docker: update libtiff to non-vulnerable version (#9033) (45e9ece)
  • json-schema-2020-12: add rendering support for type='integer' (#9031) (94fac4b), closes #9013
  • json-schema-2020-12: fix rendering of exclusiveMin|Max keywords (#9030) (70d7986), closes #9013
  • swagger-ui-react: re-enable SSR support (#9035) (21a2ef5), closes #8976

Swagger UI v5.1.2 Released!

5.1.2 (2023-07-17)

Bug Fixes

Swagger UI v5.1.1 Released!

5.1.1 (2023-07-14)

Bug Fixes

  • fix critical bug in OpenAPI 3.1.0 resolution (#9020) (b70e276)
  • swagger-ui-react: use correct default prop values (#8976) (f287339)

Swagger UI v5.1.0 Released!

5.1.0 (2023-06-19)

Features

Performance Improvements


NOTE: this release comes with performance enhancements that allow to display huge OpenAPI 3.1.0 definitions in SwaggerUI.

Swagger UI v5.0.0 Released!

5.0.0 (2023-06-12)

Release summary

... (truncated)

Commits
  • 60f39c9 chore(release): cut the v5.1.3 release
  • 21a2ef5 fix(swagger-ui-react): re-enable SSR support (#9035)
  • 58f83b6 fix(docker): fix libtiff NULL Pointer dereference issue (#9034)
  • 45e9ece fix(docker): update libtiff to non-vulnerable version (#9033)
  • 2ff8986 fix(docker): remove vulnerable libtiff (#9032)
  • 94fac4b fix(json-schema-2020-12): add rendering support for type='integer' (#9031)
  • 70d7986 fix(json-schema-2020-12): fix rendering of exclusiveMin|Max keywords (#9030)
  • b0d937e chore(deps-dev): bump @​jest/globals from 29.6.0 to 29.6.1 (#9028)
  • 2e1b7a2 chore(deps-dev): bump @​babel/cli from 7.22.5 to 7.22.9 (#9027)
  • 12e9e10 chore(deps-dev): bump @​babel/preset-env from 7.22.5 to 7.22.9 (#9026)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [swagger-ui-react](https://github.com/swagger-api/swagger-ui) from 4.12.0 to 5.1.3.
- [Release notes](https://github.com/swagger-api/swagger-ui/releases)
- [Changelog](https://github.com/swagger-api/swagger-ui/blob/master/.releaserc)
- [Commits](swagger-api/swagger-ui@v4.12.0...v5.1.3)

---
updated-dependencies:
- dependency-name: swagger-ui-react
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added type/dependencies PRs and issues specific to updating dependencies javascript Pull requests that update Javascript dependencies labels Jul 22, 2023
@github-actions github-actions bot enabled auto-merge (squash) July 22, 2023 08:58
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 29, 2023

A newer version of swagger-ui-react exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Aug 12, 2023
@agilgur5
Copy link
Contributor

The build is failing on the same syntax error as #11640. As I mentioned there, this no longer occurs in updated versions. Either later versions of swagger-ui-react fixed this, or the updated build system from #11628 fixed it.

But, I encountered a bunch of other build errors when trying to update to latest v5.4.2.

The main error is of the form:

ERROR in ./node_modules/randombytes/node_modules/safe-buffer/index.js 3:13-30
Module not found: Error: Can't resolve 'buffer' in '/Users/antongilgur/Desktop/GitHub/oss/argo-workflows/ui/node_modules/randombytes/node_modules/safe-buffer'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }'
        - install 'buffer'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "buffer": false }
 @ ./node_modules/randombytes/browser.js 13:13-42
 @ ./node_modules/swagger-ui-react/swagger-ui.js 12609:20-42
 @ ./node_modules/swagger-ui-react/index.cjs 7:40-62
 @ ./src/app/apidocs/components/apiDocs.tsx 32:41-68
 @ ./src/app/apidocs/index.tsx 3:16-47
 @ ./src/app/app-router.tsx 61:32-52
 @ ./src/app/app.tsx 30:19-42
 @ ./src/app/index.tsx 33:25-49 28:12-28

This corresponds directly to swagger-api/swagger-ui#7704 / swagger-api/swagger-ui#7893 / swagger-api/swagger-ui#7908.

Those were supposed to be fixed by swagger-api/swagger-ui#7946 which was released in v4.10.0 though.
It looks like our build is grabbing the Node bundle instead of the browser bundle.

I attempted to update our tsconfig.json to use newer module and moduleResolution -- specifically node16 -- to handle package.json#exports and package.json#imports, but that ended up:

  1. Breaking usage of some other dependencies. Their imports may need updating
  2. Not working as intended because we are on an older version of TypeScript 😭

The dependency issues started giving me a headache (literally) after all that, so think I will put updating swagger-ui-react to the side for now. We should take this one step at a time and revisit this once more of the build system has been updated (e.g. esbuild-loader, newer TS, etc)

@stale stale bot removed the problem/stale This has not had a response in some time label Aug 28, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the problem/stale This has not had a response in some time label Sep 17, 2023
@agilgur5 agilgur5 removed the problem/stale This has not had a response in some time label Oct 12, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 27, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@sarabala1979
Copy link
Member

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 27, 2023

Superseded by #12273.

@dependabot dependabot bot closed this Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 17:49

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ui/swagger-ui-react-5.1.3 branch November 27, 2023 17:49
@agilgur5
Copy link
Contributor

Rebasing or recreating won't fix this one (or a handful of the UI dependabot PRs); #12273 is still failing.

As I wrote above, this is a breaking change and requires several other dependencies to be upgraded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants