Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add support for Create React App without eject #7946

Merged
merged 7 commits into from
Mar 28, 2022

Conversation

char0n
Copy link
Member

@char0n char0n commented Mar 25, 2022

Description

This is an effort to make our primary ESM bundle work out of the box with CRA@5 (Create React App). After this PR is merged it gives us operational space to progressively eliminate (or replace by others more modern polymorphic ones) dependencies using Node.js API which needs to be poly-filled.

Requirements:

  • primary fragment must work out of the box with CRA@5 without errors or warnings
  • primary fragment must work with webpack@4
  • primary fragment must work with webpack@5
  • primary fragment must work with Jest

Refs #7898
Refs #7944
Refs #7935
Refs #7910
Refs #7908
Refs #7902

Motivation and Context

Currently we have to have quite complex resolve.fallbacks and use of ProvidePlugin to build the SwaggerUI successfully. Having primary ESM bundle being able to build with industry standard build systems without any additional configuration would be a huge gain and lower the adoption of SwaggerUI integrations.

How Has This Been Tested?

Manually with CRA@5

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n self-assigned this Mar 25, 2022
@char0n char0n marked this pull request as ready for review March 26, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant