Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump github.com/spf13/viper from 1.15.0 to 1.17.0 #12236

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Nov 21, 2023

Replaces #12002.

This is the same update as #12002 but the golangci tool has problems with the commit. This also includes an update to golangci-lint to the latest version to fix that and as good practice.

Is there a different process for fixing dependabot problems? Should I have been able to fix it without a new PR?

dependabot bot and others added 4 commits November 4, 2023 08:53
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.15.0 to 1.17.0.
- [Release notes](https://github.com/spf13/viper/releases)
- [Commits](spf13/viper@v1.15.0...v1.17.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/viper
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Alan Clucas <alan@clucas.org>
…es/github.com/spf13/viper-1.17.0

Signed-off-by: Alan Clucas <alan@clucas.org>
Signed-off-by: Alan Clucas <alan@clucas.org>
@sarabala1979 sarabala1979 enabled auto-merge (squash) November 22, 2023 14:52
@sarabala1979 sarabala1979 merged commit be70166 into argoproj:master Nov 22, 2023
27 checks passed
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Nov 23, 2023
@agilgur5
Copy link
Contributor

Is there a different process for fixing dependabot problems? Should I have been able to fix it without a new PR?

An Approver should be able to merge/rebase it with master (if there's a resolved CI issue like #12245): or retry CI (if it's a flaky test). It does need a manual touch though. A comment with @dependabot rebase might work too, though idk who dependabot allows to do that.

sarabala1979 pushed a commit that referenced this pull request Jan 10, 2024
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
@Joibel Joibel deleted the viper-1.17.0 branch January 15, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants