Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix lint check #12245

Merged
merged 1 commit into from
Nov 22, 2023
Merged

ci: Fix lint check #12245

merged 1 commit into from
Nov 22, 2023

Conversation

terrytangyuan
Copy link
Member

No description provided.

@terrytangyuan
ci: Fix lint check
4743afd 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan mentioned this pull request Nov 22, 2023
Merged
Joibel
Joibel approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

@sarabala1979 sarabala1979 enabled auto-merge (squash) November 22, 2023 14:50
@sarabala1979 sarabala1979 merged commit e515a73 into argoproj:master Nov 22, 2023
27 checks passed
@terrytangyuan terrytangyuan deleted the fix-lint branch November 22, 2023 15:01
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Nov 23, 2023
@agilgur5
Copy link
Contributor

@Yaminyam root caused this on Slack -- #12225 and #12227 had a conflict with each other that only showed up once they were both merged to the same branch

This was referenced Nov 23, 2023
Merged
Open
terrytangyuan added a commit that referenced this pull request Nov 27, 2023
@terrytangyuan
ci: Fix lint check (#12245)
713b6d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@Joibel Joibel Joibel approved these changes

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrytangyuan @agilgur5 @Joibel @sarabala1979