Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update killercoda url #12244

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Nov 22, 2023

Motivation

The Pipekit team forked the old catacoda training course and has been building it up on killercoda. This has now been merged back upstream.

This PR changes the url to the training course in the argo workflows docs.

Signed-off-by: Tim Collins <tim@thecollins.team>
@tico24 tico24 self-assigned this Nov 22, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Any reason for keeping it as draft?

@tico24
Copy link
Member Author

tico24 commented Nov 22, 2023

Any reason for keeping it as draft?

Yes. The documented submission process is that I shouldn't take it out of draft until the build is green.

### When you open your PR

...
- Create the PR as draft.
- Once builds are green, mark your PR "Ready for review".

@terrytangyuan
Copy link
Member

The failure is irrelevant. Fixing in #12245

@tico24 tico24 marked this pull request as ready for review November 22, 2023 15:21
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Nov 23, 2023
@tico24 tico24 changed the title chore: Update killercoda url docs: Update killercoda url Nov 23, 2023
@terrytangyuan terrytangyuan merged commit 2def012 into argoproj:master Nov 23, 2023
16 checks passed
agilgur5 pushed a commit that referenced this pull request May 4, 2024
Signed-off-by: Tim Collins <tim@thecollins.team>
Co-authored-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
(cherry picked from commit 2def012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants