-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1 #12459
Merged
terrytangyuan
merged 1 commit into
argoproj:main
from
roelarents:chore-update-azure-sdk-storage-azblob
Jan 5, 2024
Merged
chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1 #12459
terrytangyuan
merged 1 commit into
argoproj:main
from
roelarents:chore-update-azure-sdk-storage-azblob
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/Azure/azure-sdk-for-go/sdk/storage/azblob](https://github.com/Azure/azure-sdk-for-go) from 1.0.0 to 1.2.1. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/storage/azblob/v1.0.0...sdk/storage/azblob/v1.2.1) Signed-off-by: Roel Arents <roel.arents@kadaster.nl>
workflow/controller/operator.go
Outdated
@@ -1821,7 +1821,7 @@ type executeTemplateOpts struct { | |||
// nodeName is the name to be used as the name of the node, and boundaryID indicates which template | |||
// boundary this node belongs to. | |||
func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string, orgTmpl wfv1.TemplateReferenceHolder, tmplCtx *templateresolution.Context, args wfv1.Arguments, opts *executeTemplateOpts) (*wfv1.NodeStatus, error) { | |||
woc.log.Debugf("Evaluating node %s: template: %s, boundaryID: %s", nodeName, common.GetTemplateHolderString(orgTmpl), opts.boundaryID) | |||
woc.log.Debugf("Evaluating node %s: template: %s, boundaryID: %s, currentStackDepth: %v", nodeName, common.GetTemplateHolderString(orgTmpl), opts.boundaryID, woc.currentStackDepth) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unrelated change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
roelarents
force-pushed
the
chore-update-azure-sdk-storage-azblob
branch
from
January 5, 2024 08:22
ab4e3fb
to
9e17f4c
Compare
terrytangyuan
approved these changes
Jan 5, 2024
agilgur5
added
type/dependencies
PRs and issues specific to updating dependencies
go
Pull requests that update Go dependencies
area/artifacts
S3/GCP/OSS/Git/HDFS etc
labels
Jan 5, 2024
3 tasks
agilgur5
changed the title
chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to 1.2.1
Feb 15, 2024
agilgur5
changed the title
chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to 1.2.1
chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1
Feb 15, 2024
agilgur5
pushed a commit
that referenced
this pull request
Apr 9, 2024
) Signed-off-by: Roel Arents <roel.arents@kadaster.nl> (cherry picked from commit 29cf90e)
Backported cleanly into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/artifacts
S3/GCP/OSS/Git/HDFS etc
go
Pull requests that update Go dependencies
type/dependencies
PRs and issues specific to updating dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1.
Fixes: n/a. I didn't create an issue.
Motivation
Update azure-sdk-for-go/sdk/storage/azblob to the latest version.
Dependabot would normally do this, but it has been explicitly disabled for this dep by @alexec. Perhaps it could/should be enabled again, since @brianloss manually updated to the 1.0 version.
After updating argo from v3.4.8 to v3.5.2 we ran into this issue in the azure sdk with uploading artifacts with a particular size in which case the upload part size is not correctly calculated.
Modifications
A version update in go.mod and .sum
Also tagged on the expansion of the debug message for
executeTemplate
, to help investigating for this (unrelated) issue with the recently introduced recursion limitVerification
Tested by: