Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1 #12459

Conversation

roelarents
Copy link
Contributor

Bumps github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1.

Fixes: n/a. I didn't create an issue.

Motivation

Update azure-sdk-for-go/sdk/storage/azblob to the latest version.

Dependabot would normally do this, but it has been explicitly disabled for this dep by @alexec. Perhaps it could/should be enabled again, since @brianloss manually updated to the 1.0 version.

After updating argo from v3.4.8 to v3.5.2 we ran into this issue in the azure sdk with uploading artifacts with a particular size in which case the upload part size is not correctly calculated.

Modifications

A version update in go.mod and .sum

Also tagged on the expansion of the debug message for executeTemplate, to help investigating for this (unrelated) issue with the recently introduced recursion limit

Verification

Tested by:

  • updating this dep in 3.5.2
  • running the unit tests
  • building the argoexec image locally
  • running the same workflow that failed on it before

@roelarents roelarents marked this pull request as ready for review January 4, 2024 15:02
@@ -1821,7 +1821,7 @@ type executeTemplateOpts struct {
// nodeName is the name to be used as the name of the node, and boundaryID indicates which template
// boundary this node belongs to.
func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string, orgTmpl wfv1.TemplateReferenceHolder, tmplCtx *templateresolution.Context, args wfv1.Arguments, opts *executeTemplateOpts) (*wfv1.NodeStatus, error) {
woc.log.Debugf("Evaluating node %s: template: %s, boundaryID: %s", nodeName, common.GetTemplateHolderString(orgTmpl), opts.boundaryID)
woc.log.Debugf("Evaluating node %s: template: %s, boundaryID: %s, currentStackDepth: %v", nodeName, common.GetTemplateHolderString(orgTmpl), opts.boundaryID, woc.currentStackDepth)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unrelated change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@roelarents roelarents force-pushed the chore-update-azure-sdk-storage-azblob branch from ab4e3fb to 9e17f4c Compare January 5, 2024 08:22
@terrytangyuan terrytangyuan merged commit 29cf90e into argoproj:main Jan 5, 2024
27 checks passed
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc labels Jan 5, 2024
@roelarents roelarents deleted the chore-update-azure-sdk-storage-azblob branch January 8, 2024 12:43
@agilgur5 agilgur5 changed the title chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to 1.2.1 Feb 15, 2024
@agilgur5 agilgur5 changed the title chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob to 1.2.1 chore: bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob from 1.0.0 to 1.2.1 Feb 15, 2024
agilgur5 pushed a commit that referenced this pull request Apr 9, 2024
)

Signed-off-by: Roel Arents <roel.arents@kadaster.nl>
(cherry picked from commit 29cf90e)
@agilgur5
Copy link
Contributor

agilgur5 commented Apr 9, 2024

Backported cleanly into release-3.5 as 5c59642

@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants