fix: disable concurrency when downloading azure files

[roelarents]

workaround for Azure/azure-sdk-for-go#22156

Motivation

Recently bumped the azure sdk for go for blob storage. But it has an issue with concurrent downloads.

Modifications

Set concurrency when downloading artifacts/files/blobs from azure blob storage to 1 (instead of 5)

Verification

Tested in production with a patch on 3.5.4. We suffered from this issue before (hanging workflow steps) and now not anymore.

[agilgur5]

This sounds like it's going to be fixed soon upstream? So maybe we should just wait for the fix and update the dep rather than adding and removing a workaround. I would think the Azure SDK would have a release before Argo as well

[roelarents]

True, if they fix it before the next argo release then this is obsolete. If not, I do suggest this temporary workaround. Because there is another issue (that we also encountered in production) in the azure blob sdk since 1.0 (which is in argo 3.5). That has been fixed upstream already. I bumped the sdk to 1.2.1 for it. But that introduced this issue. (Probably/possibly there is a version in between with the fix for the one and not yet introducing the next. But I think using the latest version is easier.)

[tanyasethi-msft]

This fix constraints the concurrency to 1, which is not preferable.
We will be fixing the issue in our next release, Please use azblob v1.1.0 for temporary mitigation.

[roelarents]

yep, they fixed it. this can be closed.

[agilgur5]

Looks like it was fixed in Azure/azure-sdk-for-go#22334 which was released in azblob v1.3.0.

This PR has been replaced by #12667 as such