Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Renders namespace in UI. Fixes #1952 and #1959 #1965

Merged
merged 483 commits into from
Jan 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
483 commits
Select commit Hold shift + click to select a range
3f8b176
adds /historical-artifacts URL
alexec Jan 3, 2020
028b473
renamed "history" to "archive"
alexec Jan 3, 2020
8dd2ca7
refactored bearer code to support minikube
alexec Jan 4, 2020
b733888
lint
alexec Jan 4, 2020
3cbfb79
tidy up login
alexec Jan 4, 2020
06899d7
skip test
alexec Jan 4, 2020
bd2f49a
Added template Cli commands
sarabala1979 Jan 4, 2020
b79eb6f
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 4, 2020
eee2e02
Remove Argo CI config
alexec Jan 6, 2020
2c4056b
lint
alexec Jan 6, 2020
d7f095e
ignore ui
alexec Jan 6, 2020
f90c8c7
make clis
alexec Jan 6, 2020
e483892
chore: update cache versions
alexec Jan 6, 2020
4837c10
docs: added docs for persistance features
alexec Jan 6, 2020
03f6c35
list directory
alexec Jan 6, 2020
4a26463
docs: spelling
alexec Jan 6, 2020
a5b0585
logging
alexec Jan 6, 2020
cf7b011
work-around to circleci
alexec Jan 6, 2020
6f2f941
Update config.yml
alexec Jan 6, 2020
de9f505
Update config.yml
alexec Jan 6, 2020
3e3f900
fix: Make sql works for both mysql and postgre (#1912)
whynowy Jan 7, 2020
5e4b588
lint + sort templates + template UI as filterable list
alexec Jan 7, 2020
bfe2d97
Merge branch 'apiserverimpl' of github.com:argoproj/argo into apiserv…
alexec Jan 7, 2020
fb0ff58
updated docs
alexec Jan 7, 2020
528133d
bits and bobs
alexec Jan 7, 2020
59c0aed
search
alexec Jan 7, 2020
daa5bd2
docs + help
alexec Jan 7, 2020
e31737a
Merge branch 'master' into apiserverimpl
simster7 Jan 7, 2020
678d5ae
Fix imports
simster7 Jan 7, 2020
8962a47
Fixes:
simster7 Jan 7, 2020
4556caf
error boundary + loading
alexec Jan 7, 2020
aa73fe2
Can create workflow tempaltes from UI
simster7 Jan 7, 2020
75d2f07
removed dup delete fields
alexec Jan 7, 2020
06ffb49
lint
alexec Jan 7, 2020
39803ec
vendor
alexec Jan 7, 2020
e84719f
ui
alexec Jan 7, 2020
8f72da8
layout
alexec Jan 7, 2020
49910f5
rm yamljs
alexec Jan 7, 2020
d46ed75
Fixed NoAuth issue
sarabala1979 Jan 7, 2020
619c8aa
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 7, 2020
850669f
reduce workflow size
alexec Jan 7, 2020
a265031
ok
alexec Jan 7, 2020
079029b
continue
alexec Jan 7, 2020
bbb8434
continue
alexec Jan 7, 2020
008d19c
Remove leading space
whynowy Jan 8, 2020
ab84060
namespace filter
alexec Jan 8, 2020
2922c89
added missing labels
alexec Jan 8, 2020
350069e
help
alexec Jan 8, 2020
cf3c842
error boundary
alexec Jan 8, 2020
f5ce107
change creation endpoints
alexec Jan 8, 2020
494ef47
lint
alexec Jan 8, 2020
99b296a
refactor db logic removing unused methods
alexec Jan 8, 2020
156bafb
tidy up
alexec Jan 8, 2020
fea29e7
Cron Workflow UI Core
simster7 Jan 8, 2020
53a83d2
Cron Workflows app layer
simster7 Jan 8, 2020
1c94ed9
Upgrade argo-ui dependency
simster7 Jan 8, 2020
737aab3
deps
alexec Jan 8, 2020
3dbf433
Merge branch 'apiserverimpl' of github.com:argoproj/argo into apiserv…
alexec Jan 8, 2020
4d598eb
fix: stack overflow error
alexec Jan 8, 2020
b902a28
Enhanced log command for workflow
sarabala1979 Jan 8, 2020
77b677b
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 8, 2020
1714828
adds support to list cron workflows
alexec Jan 8, 2020
39c1bf9
enhance cron list
alexec Jan 8, 2020
551ec35
lint
alexec Jan 8, 2020
8bbc8ec
add getter cron workflows
alexec Jan 8, 2020
f7141c1
add delete for cron workflows
alexec Jan 8, 2020
442852c
small changes
alexec Jan 8, 2020
d310a9e
Re-instated namespace for creation URLs.
alexec Jan 8, 2020
14628e7
Add Created on Cronworkflow
sarabala1979 Jan 8, 2020
66a29f8
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 8, 2020
92ac216
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 8, 2020
c77bfab
fix-up
alexec Jan 9, 2020
d17e2d2
remove ResubmitArchivedWorkflom
alexec Jan 9, 2020
7cb6e49
tidy up
alexec Jan 9, 2020
b53a5e0
remove namespace from archive apis
alexec Jan 9, 2020
a5f922f
fix
alexec Jan 9, 2020
302330d
updated cron ui
alexec Jan 9, 2020
d54459a
fix phases
alexec Jan 9, 2020
399f129
clean up deps
alexec Jan 9, 2020
eacda3c
ruthless pruning of dependencies
alexec Jan 9, 2020
aba7c84
Refactored Auth Token functionality
sarabala1979 Jan 9, 2020
45646fd
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 9, 2020
61f7f7f
bug fix
alexec Jan 9, 2020
dfafb96
Delete Untitled
sarabala1979 Jan 9, 2020
9f838e2
test permission
whynowy Jan 9, 2020
b71e630
fix
alexec Jan 9, 2020
58353ae
Update manifests to ERSION
alexec Jan 9, 2020
bc8c31d
Update manifests to ERSION
alexec Jan 9, 2020
c424743
Update manifests to apiserverimpl
alexec Jan 9, 2020
eb04bd5
release
alexec Jan 9, 2020
1a926a0
bits
alexec Jan 9, 2020
f1c53bf
1
alexec Jan 9, 2020
e0f9dd9
1
alexec Jan 9, 2020
e8a0c9e
commen
alexec Jan 9, 2020
e3a40c2
lint
alexec Jan 9, 2020
6b793af
lint
alexec Jan 9, 2020
2498147
codegen
alexec Jan 9, 2020
dd5d521
faster
alexec Jan 9, 2020
79e0659
makefile
alexec Jan 9, 2020
9b09bec
goimports
alexec Jan 9, 2020
c5e278c
VERSION
alexec Jan 9, 2020
918eaa5
typo
alexec Jan 9, 2020
c5140af
makefile
alexec Jan 9, 2020
631c848
finished missing test
alexec Jan 9, 2020
6903277
corrected flag name
alexec Jan 9, 2020
efb9ab3
add TODO
alexec Jan 9, 2020
66e180c
manifests
alexec Jan 9, 2020
ea7d0d0
refactored
sarabala1979 Jan 9, 2020
bd42919
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 9, 2020
6f7ec53
snapshot
alexec Jan 9, 2020
aa18841
v1
alexec Jan 10, 2020
85f8e39
ubuntu-1604:201903-01
alexec Jan 10, 2020
5712a70
catch errors
alexec Jan 10, 2020
c9ecf82
upload assets
alexec Jan 10, 2020
f65cd6e
dep ensure
alexec Jan 10, 2020
87ce187
remove bug in upload-asset.sh
alexec Jan 10, 2020
2f79f24
lint
alexec Jan 10, 2020
84a68c6
re-instate v0
alexec Jan 10, 2020
4131e5d
only pull images ifNotPresent, so not being able to reach Docker Hub …
alexec Jan 10, 2020
a98a00b
try fix
alexec Jan 10, 2020
2a0d7d7
fix: sed invalid
alexec Jan 10, 2020
6f277da
debugging
alexec Jan 10, 2020
1625138
push
alexec Jan 10, 2020
139b09f
downloading
alexec Jan 10, 2020
d776cc4
fix install
alexec Jan 10, 2020
6f1209b
fix: should not delete artifacts
alexec Jan 10, 2020
1025669
add manifests
alexec Jan 10, 2020
898f974
skip tests
alexec Jan 10, 2020
2ac5bf6
latest
alexec Jan 10, 2020
22b836f
latest
alexec Jan 10, 2020
b66d299
increase timeout
alexec Jan 10, 2020
823ba8b
yamls
alexec Jan 10, 2020
96f1ec9
quick-start
alexec Jan 10, 2020
3560bb9
yamls
alexec Jan 10, 2020
defda9e
chore: remove make of clis
alexec Jan 10, 2020
1f79091
Merge tag 'apiserverimpl' of github.com:argoproj/argo into apiserverimpl
alexec Jan 10, 2020
d676c67
Merge branch 'apiserverimpl' of github.com:argoproj/argo into apiserv…
alexec Jan 10, 2020
bf12b53
install kustomize
alexec Jan 10, 2020
0307e2e
codegen
alexec Jan 10, 2020
912be93
k3
alexec Jan 10, 2020
629ce06
docs: update releasing.md
alexec Jan 10, 2020
c0905a1
chore: add missing .codecov.yaml
alexec Jan 10, 2020
257a841
chore: try to install kustomize .. again
alexec Jan 10, 2020
edd21f7
chore: add `make pre-push`
alexec Jan 10, 2020
fbac0cd
fix: chmod pre-push hook
alexec Jan 10, 2020
d79bc93
/.vendor-new
alexec Jan 10, 2020
87cb8e2
delete .vendor-new if exists
alexec Jan 10, 2020
c75a496
chore: create dist dir
alexec Jan 10, 2020
68ac298
rename file
alexec Jan 10, 2020
93500b1
run e2e test pre-push
alexec Jan 10, 2020
6ea8c5d
pf
alexec Jan 10, 2020
dbd33cc
mkdir dist for CI
alexec Jan 10, 2020
e793564
added TODO for argo-server role
alexec Jan 10, 2020
e4e4b2e
re-order CI config
alexec Jan 10, 2020
6e42c2c
fix: try fix pf
alexec Jan 10, 2020
ca48000
fix: background portforward on CI
alexec Jan 10, 2020
1575035
feat: upload swagger assets to release
alexec Jan 10, 2020
0ec6e94
updated manifests
alexec Jan 10, 2020
5f5f187
remove redundancy
alexec Jan 10, 2020
d0946e5
add pre-commit target
alexec Jan 10, 2020
d154ede
added readinessProbe
alexec Jan 11, 2020
3fc61e6
add GCP authprovider and fixed in list call
sarabala1979 Jan 11, 2020
5ac8b0c
fixed lint
sarabala1979 Jan 11, 2020
8a21c24
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 11, 2020
4302c43
lint
alexec Jan 11, 2020
54ab1bc
chore: logging
alexec Jan 11, 2020
ac8a62f
listen on 0.0.0.0:2746
alexec Jan 11, 2020
90a7931
added v2 token
alexec Jan 11, 2020
0c81d73
feat: add argo-server service account
alexec Jan 11, 2020
c9ce631
updated roles
alexec Jan 11, 2020
d5da88d
re-order build
alexec Jan 11, 2020
640e8d1
ci: fix build
alexec Jan 11, 2020
90a9d07
update manifests
alexec Jan 11, 2020
f6e4551
revert
alexec Jan 11, 2020
41e2189
do not scale down deployment, maybe this will fix CI
alexec Jan 11, 2020
8010e69
adds --force-namespace-isolation to controller
alexec Jan 11, 2020
962065c
typo
alexec Jan 11, 2020
191f1bb
namespace
alexec Jan 11, 2020
a47759e
1m
alexec Jan 11, 2020
607cfd9
namespace: argo
alexec Jan 11, 2020
c25cbff
adds --force-namespace-isolation
alexec Jan 11, 2020
4b3e965
FORCE_NAMESPACE_ISOLATION
alexec Jan 11, 2020
5d31a06
logging
alexec Jan 11, 2020
37d5c45
bug
alexec Jan 11, 2020
145eb6d
logging
alexec Jan 11, 2020
a24db6b
fix namespace
alexec Jan 11, 2020
eba9582
add delay
alexec Jan 11, 2020
fd0dc30
run smoke tests before e2e on CI
alexec Jan 11, 2020
aa7d7c5
add debug logging
alexec Jan 11, 2020
3280038
added guard of condition
alexec Jan 11, 2020
e2b8166
simplify update
alexec Jan 11, 2020
6f49e62
fix: send offloaded node status to watch
alexec Jan 11, 2020
2b88dca
test: add wait for workflow to be deleted
alexec Jan 11, 2020
0ae6b19
test: print more diagnostics on failure
alexec Jan 11, 2020
29fb493
chore: spelling
alexec Jan 11, 2020
fafdd9b
chore: remove debug logging
alexec Jan 11, 2020
ae99a28
test: watch should return offloaded node status
alexec Jan 11, 2020
0f89ff7
chore: added comments
alexec Jan 11, 2020
50acdbc
cron isolated informer
alexec Jan 11, 2020
6a325a5
roles
alexec Jan 11, 2020
4ee7602
get nodes
alexec Jan 11, 2020
a9de24a
lint
alexec Jan 11, 2020
5334c60
stuff
alexec Jan 11, 2020
bb004b1
postgres.host=localhost
alexec Jan 11, 2020
89805df
Incorporated Jesse Initial Comments
sarabala1979 Jan 12, 2020
c1ea1bd
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 12, 2020
96cfc44
Update workflow_server_test.go
sarabala1979 Jan 12, 2020
2b0f786
Update workflow_server_test.go
sarabala1979 Jan 12, 2020
80b230c
Update workflow_server_test.go
sarabala1979 Jan 12, 2020
9e4bba9
incorporated Jesse comments
sarabala1979 Jan 12, 2020
f2bc0c8
Merge branch 'master' into apiserverimpl
simster7 Jan 13, 2020
79ed7ff
New CLI tests
simster7 Jan 13, 2020
51dcb1c
Merge branch 'master' into apiserverimpl
simster7 Jan 13, 2020
db68dbd
Adds diagnostics to tests.
alexec Jan 13, 2020
43ac0ec
Minor test rework
simster7 Jan 13, 2020
18058f5
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
simster7 Jan 13, 2020
cc166ea
Removed Kubeservice
sarabala1979 Jan 13, 2020
f840729
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
sarabala1979 Jan 13, 2020
38d20e0
Fix CronWorkflow tests
simster7 Jan 13, 2020
bbbadcb
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
simster7 Jan 13, 2020
c4ae91c
disable forcing off offloading
alexec Jan 13, 2020
01c6e9e
Add workflow create verb to namespace install
simster7 Jan 13, 2020
690e05a
Skip legacy test
simster7 Jan 13, 2020
960d962
add github action
alexec Jan 14, 2020
bc1092b
fix links
alexec Jan 14, 2020
19185f7
fix for code review comment
alexec Jan 14, 2020
5aa433a
remove quick start
alexec Jan 14, 2020
adbfffe
fix version
alexec Jan 14, 2020
bc3da04
Merge branch 'apiserverimpl' of github.com:argoproj/argo into apiserv…
alexec Jan 14, 2020
b4a7e05
reinstate behaviour of Dockerfile
alexec Jan 14, 2020
4b3e827
Added WorkflowTemplate test infra and smoke test
simster7 Jan 14, 2020
f8378db
Merge branch 'apiserverimpl' of https://github.com/argoproj/argo into…
simster7 Jan 14, 2020
7d89014
logging
alexec Jan 14, 2020
6caa777
re-order more flakey task earlier
alexec Jan 14, 2020
9ea3ed8
chore: Removes FORCE_NAMESPACE_ISOLATION. Fixes #1952
alexec Jan 14, 2020
1cd7124
Dockerfile
alexec Jan 14, 2020
64d15e4
lock yarn for speed
alexec Jan 14, 2020
08d76c3
update watch
alexec Jan 14, 2020
33f3b41
Merge branch 'master' into apiserverimpl
alexec Jan 14, 2020
a6b421c
post-merge fixes
alexec Jan 14, 2020
e2d4a7f
work!
alexec Jan 14, 2020
b61fe1a
more logging
alexec Jan 14, 2020
cbdd612
First stab at rendering the managed namespace in the UI
alexec Jan 14, 2020
f8aae17
Merge branch 'rm-env-var' into info
alexec Jan 14, 2020
48d431d
updates Makefile
alexec Jan 14, 2020
431813e
update Makefile
alexec Jan 14, 2020
ae9ce3b
Merge branch 'master' into info
alexec Jan 15, 2020
876507f
lint
alexec Jan 15, 2020
57efa40
make manifests
alexec Jan 15, 2020
8eaeae4
Makefile
alexec Jan 15, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ ifeq ($(CI),false)
endif
# Patch deployments
kubectl -n argo patch deployment/workflow-controller --type json --patch '[{"op": "replace", "path": "/spec/template/spec/containers/0/imagePullPolicy", "value": "Never"}, {"op": "replace", "path": "/spec/template/spec/containers/0/args", "value": ["--loglevel", "debug", "--executor-image", "$(IMAGE_NAMESPACE)/argoexec:$(IMAGE_TAG)", "--executor-image-pull-policy", "Never", "--namespaced"]}]}]'
kubectl -n argo patch deployment/argo-server --type json --patch '[{"op": "replace", "path": "/spec/template/spec/containers/0/imagePullPolicy", "value": "Never"}, {"op": "replace", "path": "/spec/template/spec/containers/0/args", "value": ["--loglevel", "debug", "--auth-mode", "client"]}, {"op": "add", "path": "/spec/template/spec/containers/0/env", "value": [{"name": "ARGO_V2_TOKEN", "value": "password"}]}]'
kubectl -n argo patch deployment/argo-server --type json --patch '[{"op": "replace", "path": "/spec/template/spec/containers/0/imagePullPolicy", "value": "Never"}, {"op": "replace", "path": "/spec/template/spec/containers/0/args", "value": ["--loglevel", "debug", "--auth-mode", "client", "--namespaced"]}, {"op": "add", "path": "/spec/template/spec/containers/0/env", "value": [{"name": "ARGO_V2_TOKEN", "value": "password"}]}]'
ifeq ($(CI),false)
make up
endif
Expand Down
37 changes: 22 additions & 15 deletions cmd/server/apiserver/argoserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/argoproj/argo/cmd/server/artifacts"
"github.com/argoproj/argo/cmd/server/auth"
"github.com/argoproj/argo/cmd/server/cronworkflow"
"github.com/argoproj/argo/cmd/server/info"
"github.com/argoproj/argo/cmd/server/static"
"github.com/argoproj/argo/cmd/server/workflow"
"github.com/argoproj/argo/cmd/server/workflowarchive"
Expand All @@ -38,28 +39,31 @@ import (
)

type argoServer struct {
namespace string
kubeClientset *kubernetes.Clientset
authenticator auth.Gatekeeper
configName string
stopCh chan struct{}
namespace string
managedNamespace string
kubeClientset *kubernetes.Clientset
authenticator auth.Gatekeeper
configName string
stopCh chan struct{}
}

type ArgoServerOpts struct {
Namespace string
KubeClientset *kubernetes.Clientset
WfClientSet *versioned.Clientset
RestConfig *rest.Config
AuthMode string
ConfigName string
Namespace string
KubeClientset *kubernetes.Clientset
WfClientSet *versioned.Clientset
RestConfig *rest.Config
AuthMode string
ConfigName string
ManagedNamespace string
}

func NewArgoServer(opts ArgoServerOpts) *argoServer {
return &argoServer{
namespace: opts.Namespace,
kubeClientset: opts.KubeClientset,
authenticator: auth.NewGatekeeper(opts.AuthMode, opts.WfClientSet, opts.KubeClientset, opts.RestConfig),
configName: opts.ConfigName,
namespace: opts.Namespace,
managedNamespace: opts.ManagedNamespace,
kubeClientset: opts.KubeClientset,
authenticator: auth.NewGatekeeper(opts.AuthMode, opts.WfClientSet, opts.KubeClientset, opts.RestConfig),
configName: opts.ConfigName,
}
}

Expand Down Expand Up @@ -167,6 +171,8 @@ func (as *argoServer) newGRPCServer(offloadNodeStatusRepo sqldb.OffloadNodeStatu
}

grpcServer := grpc.NewServer(sOpts...)

info.RegisterInfoServiceServer(grpcServer, info.NewInfoServer(as.managedNamespace))
workflow.RegisterWorkflowServiceServer(grpcServer, workflow.NewWorkflowServer(offloadNodeStatusRepo))
workflowtemplate.RegisterWorkflowTemplateServiceServer(grpcServer, workflowtemplate.NewWorkflowTemplateServer())
cronworkflow.RegisterCronWorkflowServiceServer(grpcServer, cronworkflow.NewCronWorkflowServer())
Expand Down Expand Up @@ -200,6 +206,7 @@ func (as *argoServer) newHTTPServer(ctx context.Context, port int, artifactServe
// we use our own Marshaler
gwMuxOpts := runtime.WithMarshalerOption(runtime.MIMEWildcard, new(json.JSONMarshaler))
gwmux := runtime.NewServeMux(gwMuxOpts)
mustRegisterGWHandler(info.RegisterInfoServiceHandlerFromEndpoint, ctx, gwmux, endpoint, dialOpts)
mustRegisterGWHandler(workflow.RegisterWorkflowServiceHandlerFromEndpoint, ctx, gwmux, endpoint, dialOpts)
mustRegisterGWHandler(workflowtemplate.RegisterWorkflowTemplateServiceHandlerFromEndpoint, ctx, gwmux, endpoint, dialOpts)
mustRegisterGWHandler(cronworkflow.RegisterCronWorkflowServiceHandlerFromEndpoint, ctx, gwmux, endpoint, dialOpts)
Expand Down
Loading