Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Renders namespace in UI. Fixes #1952 and #1959 #1965

Merged
merged 483 commits into from
Jan 15, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 14, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Depends on #1331

@alexec alexec changed the title feat: Renders namespace in UI. feat: Renders namespace in UI. Fixes #1952 Jan 14, 2020
@alexec alexec changed the title feat: Renders namespace in UI. Fixes #1952 feat: Renders namespace in UI. Fixes #1952 and #1959 Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@14d5803). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1965   +/-   ##
========================================
  Coverage          ?   8.88%           
========================================
  Files             ?      53           
  Lines             ?   33608           
  Branches          ?       0           
========================================
  Hits              ?    2985           
  Misses            ?   30233           
  Partials          ?     390

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d5803...8eaeae4. Read the comment docs.

@alexec alexec marked this pull request as ready for review January 15, 2020 04:54
@alexec alexec changed the base branch from apiserverimpl to master January 15, 2020 19:47
@alexec alexec merged commit dd704dd into argoproj:master Jan 15, 2020
@alexec alexec deleted the info branch January 15, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants